feat(storage): internal uploadData implementation #13888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
commented
Oct 7, 2024
| /** | ||
| * Generic types that extend the public non-copy API input types with extended | ||
| * options. This is a temporary solution to support advanced options from internal APIs. | ||
| */ | ||
| type ExtendInputWithAdvancedOptions<InputType, ExtendedOptionsType> = | ||
| InputType extends StorageOperationInputWithPath & | ||
| StorageOperationOptionsInput<infer PublicInputOptionsType> | ||
| ? { | ||
| path: InputType['path']; | ||
| ? InputType & { |
There was a problem hiding this comment.
This change to support the uploadData input which contains additonal data properties besides path.
AllanZhengYP
requested review from
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
ashwinkumar6
previously approved these changes
Oct 9, 2024
Samaritan1011001
previously approved these changes
Oct 9, 2024
…o storage-browser/internals-upload
AllanZhengYP
dismissed stale reviews from Samaritan1011001 and ashwinkumar6
via
c54e21e
ashika112
approved these changes
Oct 9, 2024
ashwinkumar6
approved these changes
Oct 9, 2024
AllanZhengYP
merged commit fb4237b
into
aws-amplify:storage-browser/integrity
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
uploadDatafolder toproviders/s3/apis/internalfolderuploadDataAPIIssue #, if available
Description of how you validated changes
Unit test
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.