Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter-nextjs): support next.js 15 #13947

Merged
merged 14 commits into from
Dec 11, 2024
Merged

feat(adapter-nextjs): support next.js 15 #13947

merged 14 commits into from
Dec 11, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Oct 22, 2024

Description of changes

  • Adapt the next.js breaking change (cookies from next/headers is now async [reference])

Issue #, if available

#13924

Description of how you validated changes

  1. npx next build
  2. unit tests
  3. automated e2e tests with a sample app that uses Next.js v15
  4. automated e2e tests with a smaple app that uses Next.js v14 (backwards compatibility)
  5. manual testing

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

): CookieStorage.Adapter => {
const cookieStore = cookies();
): Promise<CookieStorage.Adapter> => {
const cookieStore = await cookies();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔

@HuiSF HuiSF marked this pull request as ready for review October 23, 2024 18:23
@HuiSF HuiSF requested review from haverchuck, cshfang and a team as code owners October 23, 2024 18:23
@HuiSF HuiSF force-pushed the feat/next-15/main branch from d36fbe2 to 1a80291 Compare October 24, 2024 20:00
@HuiSF HuiSF force-pushed the feat/next-15/main branch from 1a80291 to 7992a88 Compare October 24, 2024 20:02
jjarvisp
jjarvisp previously approved these changes Oct 26, 2024
AllanZhengYP
AllanZhengYP previously approved these changes Nov 5, 2024
cshfang
cshfang previously approved these changes Nov 26, 2024
.github/workflows/push-preid-release.yml Outdated Show resolved Hide resolved
@HuiSF HuiSF dismissed stale reviews from cshfang, AllanZhengYP, and jjarvisp via 3b462ef December 5, 2024 17:50
@HuiSF HuiSF requested a review from sktimalsina as a code owner December 5, 2024 17:50
@HuiSF HuiSF force-pushed the feat/next-15/main branch from 3b462ef to 5221c49 Compare December 5, 2024 18:10
@HuiSF HuiSF force-pushed the feat/next-15/main branch from 5221c49 to fd1c642 Compare December 5, 2024 18:37
@HuiSF HuiSF removed the request for review from haverchuck December 11, 2024 20:35
@HuiSF HuiSF merged commit 341eee2 into main Dec 11, 2024
30 checks passed
@HuiSF HuiSF deleted the feat/next-15/main branch December 11, 2024 23:20
joon-won added a commit to joon-won/amplify-js that referenced this pull request Dec 11, 2024
feat(adapter-nextjs): support next.js 15 (aws-amplify#13947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants