Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-graphql): events url pattern; non-retryable error handling #13970

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

iartemiev
Copy link
Member

Description of changes

  1. Fixes HTTP -> realtime URL transformation for events
  2. Fixes non-retryable error handling
  3. Tests for ^

Description of how you validated changes

  1. Manual
  2. Added unit tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested review from a team as code owners October 29, 2024 16:43
@iartemiev iartemiev changed the title Feat/events/main fix(api-graphql): events url pattern; non-retryable error handling Oct 29, 2024
Copy link

⚠️ This PR includes changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not manually change "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library
  • Remove any export paths without a major version bump

A repository administrator is required to review this change.


import { AWSAppSyncEventProvider } from '../src/Providers/AWSAppSyncEventsProvider';

describe('AppSyncEventProvider', () => {
Copy link
Member Author

@iartemiev iartemiev Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are duplicated from AppSyncRealtimeProvider tests, but the tests include the event-specific error response shapes to test retryable/non-retryable error handling

@iartemiev iartemiev merged commit e0fdeb7 into main Oct 29, 2024
30 checks passed
@iartemiev iartemiev deleted the feat/events/main branch October 29, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants