Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql to latest version. #3309

Closed
wants to merge 2 commits into from
Closed

Conversation

EmanH
Copy link

@EmanH EmanH commented May 19, 2019

Fix issue #3274, #1891 by upgrading graphql package to latest version.

graphql/graphql-js#1536 (comment)_

This solved the issue in my project.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JustFly1984
Copy link

I think you need to set graphql to peer dependencies, and add ^ before the version

@haverchuck haverchuck requested a review from manueliglesias May 21, 2019 21:27
@haverchuck
Copy link
Contributor

@EmanH There are potentially some issues with this upgrade (althought obviously it would fix some other issues)... we will need to discuss it.

@sammartinez
Copy link
Contributor

@EmanH There is a peer dependency in react native for graphql. Please make this update there as well.

@stale
Copy link

stale bot commented Jul 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 25, 2019

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.

@stale stale bot closed this Jul 25, 2019
@stale
Copy link

stale bot commented Aug 1, 2019

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants