fix(@aws-amplify/analytics): do not send events when analytics modules not configured #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanranz
approved these changes
Jul 9, 2019
tjleing
pushed a commit
to tjleing/amplify-js
that referenced
this pull request
Jul 19, 2019
jordanranz
pushed a commit
that referenced
this pull request
Jul 22, 2019
* Added data-test attributes to React and Angular Sumerian Scene components * Bump version back down (after using Verdaccio) * Added some more data-type elements and used includes instead of hardcoded strings * query string parsing and customChallenge Cognito response case (#3608) * query string parsing and customChallenge Cognito response case * checking for metadata from cognito response * unit tests for react and vue * fix(@aws-amplify/analytics): do not send events when analytics modules not configured (#3614) * Added data-test attributes to React and Angular Sumerian Scene components * Bump version back down (after using Verdaccio) * chore(release): Publish [ci skip] - @aws-amplify/analytics@1.2.18-unstable.1 - aws-amplify-angular@3.0.5-unstable.2 - aws-amplify-react@2.3.10-unstable.2 - aws-amplify-vue@0.2.13-unstable.0 - aws-amplify@1.1.30-unstable.2 * chore(release): Publish [ci skip] - @aws-amplify/analytics@1.2.18 - @aws-amplify/api@1.0.37 - @aws-amplify/auth@1.2.26 - aws-amplify-angular@3.0.5 - aws-amplify-react-native@2.1.14 - aws-amplify-react@2.3.10 - aws-amplify-vue@0.2.13 - aws-amplify@1.1.30 * Allow customers to add a custom state to federatedSignIn method (#3588) * Update auth state * Remove unneeded comments * updating `isCustomStatePresent` to `combinedState` * Updating naming conventions * chore(release): Publish [ci skip] - @aws-amplify/api@1.0.38-unstable.0 - @aws-amplify/auth@1.2.27-unstable.0 - aws-amplify-angular@3.0.6-unstable.0 - aws-amplify@1.1.31-unstable.0 * Added some more data-type elements and used includes instead of hardcoded strings * Revert package-lock.json and yarn.lock * Newlines at end of lockfiles to get rid of diff
jordanranz
pushed a commit
that referenced
this pull request
Jul 22, 2019
…#3710) * Added data-test attributes to React and Angular Sumerian Scene components * Bump version back down (after using Verdaccio) * Added some more data-type elements and used includes instead of hardcoded strings * query string parsing and customChallenge Cognito response case (#3608) * query string parsing and customChallenge Cognito response case * checking for metadata from cognito response * unit tests for react and vue * fix(@aws-amplify/analytics): do not send events when analytics modules not configured (#3614) * Added data-test attributes to React and Angular Sumerian Scene components * Bump version back down (after using Verdaccio) * chore(release): Publish [ci skip] - @aws-amplify/analytics@1.2.18-unstable.1 - aws-amplify-angular@3.0.5-unstable.2 - aws-amplify-react@2.3.10-unstable.2 - aws-amplify-vue@0.2.13-unstable.0 - aws-amplify@1.1.30-unstable.2 * chore(release): Publish [ci skip] - @aws-amplify/analytics@1.2.18 - @aws-amplify/api@1.0.37 - @aws-amplify/auth@1.2.26 - aws-amplify-angular@3.0.5 - aws-amplify-react-native@2.1.14 - aws-amplify-react@2.3.10 - aws-amplify-vue@0.2.13 - aws-amplify@1.1.30 * Allow customers to add a custom state to federatedSignIn method (#3588) * Update auth state * Remove unneeded comments * updating `isCustomStatePresent` to `combinedState` * Updating naming conventions * chore(release): Publish [ci skip] - @aws-amplify/api@1.0.38-unstable.0 - @aws-amplify/auth@1.2.27-unstable.0 - aws-amplify-angular@3.0.6-unstable.0 - aws-amplify@1.1.31-unstable.0 * Added some more data-type elements and used includes instead of hardcoded strings * Revert package-lock.json and yarn.lock * Newlines at end of lockfiles to get rid of diff * Move data-test=sumerianScene.loading so that it actually appears in the DOM
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The
signIn,signUpevents will be sent no matter analytics module is configured or not.Description of changes:
Stop sending those events when analytics or auth module is not configured. This can be done by checking the flags
authConfiguredandanalyticsConfiguredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.