fix: sourcemaps for CSS, weird paths, /predictions #4216
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR fixes a remaining handful of sourcemap issues remaining after my previous sourcemap-related PRs #3059 and #2680:
.
to these paths, e.g../src/foo.css
->../src/foo.css
configureWebpack
setting in its configwebpack/universalModuleDefinition
orwebpack/bootstrap 21c2cca6cf7a65b395b7
orfs (ignored)
. The logic in Fix sourcemap paths #3059 would pre-pendwebpack:///
to these paths which would trigger warnings in tools like source-map-loader that consume sourcemaps. This PR removes that prefix if a path is already a weird webpack path, which prevents those warnings.webpack:///
as a fall-through case, even when the path was already a valid relative URL and didn't need that prefix. Also, according to @loganfsmyth (the most knowledgeable sourcemap expert I know), OSS library sourcemaps should always use relative URLs and should never use the webpack:/// prefix. Therefore, this PR removes that prefix.predictions
library in this repoBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.