Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix builds that were broken by new terser 4.6.8 version #5233

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

Amplifiyer
Copy link
Contributor

_Issue #, if available:_terser/terser#624

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #5233 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5233   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         193      193           
  Lines       11450    11450           
  Branches     2221     2305   +84     
=======================================
  Hits         8379     8379           
+ Misses       2923     2907   -16     
- Partials      148      164   +16     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 31.25% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.09% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 17.33% <0.00%> (ø)
...ackages/datastore/src/storage/adapter/indexeddb.ts 73.26% <0.00%> (ø)
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 66.66% <0.00%> (ø)
...ages/datastore/src/sync/processors/subscription.ts 43.91% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d630c34...a66aaa8. Read the comment docs.

@Amplifiyer Amplifiyer merged commit 71044ae into master Mar 30, 2020
@Amplifiyer Amplifiyer deleted the terser-fix branch March 31, 2020 00:37
This was referenced Jan 14, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants