Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: zlib fix using npm-packlist #6650

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

iartemiev
Copy link
Member

@iartemiev iartemiev commented Aug 25, 2020

I've been noticing that sometimes even with the retry logic, CCI jobs will error out with the zlib error (after 5 retries).
Going to try this suggested fix: lerna/lerna#2278 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ashika01 ashika01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Let try this out..

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #6650 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6650   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files         208      208           
  Lines       12941    12941           
  Branches     2436     2436           
=======================================
  Hits         9477     9477           
  Misses       3301     3301           
  Partials      163      163           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794c1da...7b6fa95. Read the comment docs.

@iartemiev iartemiev merged commit ff40d12 into aws-amplify:main Aug 25, 2020
@iartemiev iartemiev deleted the zlib-fix branch August 25, 2020 18:46
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
iartemiev added a commit that referenced this pull request Oct 13, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZlibError when calling publish
3 participants