fix: fix bug where required fields were not being enforced #8455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, if a user added custom form fields and wanted them to be "required", they weren't actually being enforced as required fields. This PR changes that by adding the
required
prop to ouramplify-input
, which generates the actualinput
field on the page.It also moves the
required
prop from the parentamplify-form-field
component in the phone form field to the text input field, as having therequired
on the top level actually didn't enforce it properly and sometimes caused a bug where the form field was untargettable.Issue #, if available
#6885
Description of how you validated changes
Test locally in UI. GIF showing how it works -
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.