Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy loading belongs to #8859

Closed
wants to merge 19 commits into from
Closed

Lazy loading belongs to #8859

wants to merge 19 commits into from

Conversation

ArkamJ
Copy link
Contributor

@ArkamJ ArkamJ commented Sep 7, 2021

Description of changes

Lazy Loading added to items with BelongsTo relationships

Issue #, if available

Description of how you validated changes

Added Unit test and modified eager loading tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

iartemiev and others added 13 commits September 2, 2021 15:22
@iartemiev
feat(@aws-amplify/datastore): add SQLite storage adapter option for R…
46ee5dd 
…N apps (#8809)
@iartemiev
fix(@aws-amplify/datastore): patch immer vuln (#8841)
6521a57
@iartemiev
chore: preparing release
680a265
chore(release): Publish [ci skip]
5f595ae 
 - @aws-amplify/ui-angular@1.0.21
 - @aws-amplify/ui-components@1.7.5
 - @aws-amplify/ui-react@1.2.12
 - @aws-amplify/ui-storybook@2.0.12
 - @aws-amplify/ui-vue@1.1.6
 - @aws-amplify/analytics@5.0.12
 - @aws-amplify/api-graphql@2.2.1
 - @aws-amplify/api-rest@2.0.12
 - @aws-amplify/api@4.0.12
 - @aws-amplify/auth@4.3.2
 - aws-amplify-angular@6.0.12
 - aws-amplify-react@5.0.12
 - aws-amplify@4.2.6
 - @aws-amplify/cache@4.0.14
 - @aws-amplify/core@4.2.6
 - @aws-amplify/datastore-storage-adapter@1.1.0
 - @aws-amplify/datastore@3.4.0
 - @aws-amplify/interactions@4.0.12
 - @aws-amplify/predictions@4.0.12
 - @aws-amplify/pubsub@4.1.4
 - @aws-amplify/pushnotification@4.2.6
 - @aws-amplify/storage@4.3.7
 - @aws-amplify/xr@3.0.12
chore(release): update version.ts [ci skip]
32c0c39
Added LazyLoading + Unit Test
d4a832a
@iartemiev
fix(@aws-amplify/datastore): only stringify nested AWSJSON in mutatio…
0febaac 
…n event (#8844)
@iartemiev
chore: preparing release
f5d0ffb
chore(release): Publish [ci skip]
5e679c5 
 - @aws-amplify/ui-angular@1.0.22
 - @aws-amplify/ui-components@1.7.6
 - @aws-amplify/ui-react@1.2.13
 - @aws-amplify/ui-storybook@2.0.13
 - @aws-amplify/ui-vue@1.1.7
 - @aws-amplify/analytics@5.0.13
 - @aws-amplify/api-graphql@2.2.2
 - @aws-amplify/api-rest@2.0.13
 - @aws-amplify/api@4.0.13
 - @aws-amplify/auth@4.3.3
 - aws-amplify-angular@6.0.13
 - aws-amplify-react@5.0.13
 - aws-amplify@4.2.7
 - @aws-amplify/cache@4.0.15
 - @aws-amplify/core@4.2.7
 - @aws-amplify/datastore-storage-adapter@1.1.1
 - @aws-amplify/datastore@3.4.1
 - @aws-amplify/interactions@4.0.13
 - @aws-amplify/predictions@4.0.13
 - @aws-amplify/pubsub@4.1.5
 - @aws-amplify/pushnotification@4.2.7
 - @aws-amplify/storage@4.3.8
 - @aws-amplify/xr@3.0.13
chore(release): update version.ts [ci skip]
d815f8b
@aws-eddy
chore(fix axios version): patch security vuln for api-rest and storage (
836c94a 
#8858)
all eager loading changed to lazy
9d5f9ab
@ArkamJ
Merge branch 'aws-amplify:main' into LazyLoadingBelongsTo
31abde9
@ArkamJ ArkamJ requested a review from svidgen September 7, 2021 18:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021 •
edited
Loading

Codecov Report

Merging #8859 (51f4b42) into datastore-laziness (48b76e1) will increase coverage by 0.05%.
The diff coverage is 81.55%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           datastore-laziness    #8859      +/-   ##
======================================================
+ Coverage               77.81%   77.87%   +0.05%     
======================================================
  Files                     240      243       +3     
  Lines                   17198    17496     +298     
  Branches                 3680     3765      +85     
======================================================
+ Hits                    13383    13625     +242     
- Misses                   3690     3743      +53     
- Partials                  125      128       +3
Impacted Files Coverage Δ
packages/datastore/src/sync/index.ts 13.35% <ø> (ø)
packages/datastore/src/types.ts 80.40% <10.00%> (-4.60%) ⬇️
packages/datastore/src/sync/utils.ts 87.90% <66.66%> (-0.71%) ⬇️
packages/datastore/src/util.ts 84.00% <66.66%> (-0.36%) ⬇️
packages/datastore/src/datastore/datastore.ts 79.86% <70.58%> (-0.66%) ⬇️
...tastore-storage-adapter/src/SQLiteAdapter/types.ts 73.91% <73.91%> (ø)
...e-storage-adapter/src/SQLiteAdapter/SQLiteUtils.ts 87.08% <87.08%> (ø)
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)
...ges/datastore-storage-adapter/__tests__/helpers.ts 100.00% <100.00%> (ø)
packages/datastore/src/index.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b76e1...51f4b42. Read the comment docs.

aws-amplify-bot and others added 5 commits September 7, 2021 19:17
chore(release): Publish [ci skip]
2346129 
 - @aws-amplify/ui-angular@1.0.23
 - @aws-amplify/ui-components@1.7.7
 - @aws-amplify/ui-react@1.2.14
 - @aws-amplify/ui-storybook@2.0.14
 - @aws-amplify/ui-vue@1.1.8
 - @aws-amplify/analytics@5.0.14
 - @aws-amplify/api-graphql@2.2.3
 - @aws-amplify/api-rest@2.0.14
 - @aws-amplify/api@4.0.14
 - @aws-amplify/auth@4.3.4
 - aws-amplify-angular@6.0.14
 - aws-amplify-react@5.0.14
 - aws-amplify@4.2.8
 - @aws-amplify/cache@4.0.16
 - @aws-amplify/core@4.2.8
 - @aws-amplify/datastore-storage-adapter@1.1.2
 - @aws-amplify/datastore@3.4.2
 - @aws-amplify/interactions@4.0.14
 - @aws-amplify/predictions@4.0.14
 - @aws-amplify/pubsub@4.1.6
 - @aws-amplify/pushnotification@4.2.8
 - @aws-amplify/storage@4.3.9
 - @aws-amplify/xr@3.0.14
chore(release): update version.ts [ci skip]
f76e7f9
@ArkamJ
Merge branch 'aws-amplify:main' into LazyLoadingBelongsTo
c224067
Merge branch 'main' into LazyLoadingBelongsTo
19aeb92
Merge branch 'LazyLoadingBelongsTo' of https://github.com/ArkamJ/ampl…
51f4b42 
…ify-js into LazyLoadingBelongsTo
@ArkamJ ArkamJ closed this Sep 7, 2021
This was referenced Sep 16, 2021
Merged
Merged
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@svidgen svidgen Awaiting requested review from svidgen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ArkamJ @codecov-commenter @immutable-pro @iartemiev @aws-eddy @hkjpotato