Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@aws-amplify/storage): throw error if all upload parts complete but upload cannot be finished #9317

Merged
merged 22 commits into from
May 16, 2022
Merged

fix(@aws-amplify/storage): throw error if all upload parts complete but upload cannot be finished #9317

merged 22 commits into from
May 16, 2022

Conversation

katiegoines
Copy link
Contributor

@katiegoines katiegoines commented Dec 6, 2021 •
edited
Loading

Description of changes

Added error thrown when multi-part upload cannot be finalized.

Issue #, if available

Issue #8781

Description of how you validated changes

Tested in sample app for multi-part upload (both resumable and non-resumable)

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021 •
edited
Loading

Codecov Report

Merging #9317 (bfba02f) into main (9831d3d) will increase coverage by 4.76%.
The diff coverage is 85.38%.

@@            Coverage Diff             @@
##             main    #9317      +/-   ##
==========================================
+ Coverage   78.34%   83.11%   +4.76%     
==========================================
  Files         250      257       +7     
  Lines       18339    18550     +211     
  Branches     3955     3993      +38     
==========================================
+ Hits        14368    15418    +1050     
+ Misses       3840     3036     -804     
+ Partials      131       96      -35
Impacted Files Coverage Δ
packages/core/src/constants.ts 100.00% <ø> (ø)
packages/datastore/src/sync/index.ts 73.16% <ø> (+59.74%) ⬆️
packages/datastore/src/sync/merger.ts 91.30% <ø> (ø)
packages/datastore/src/sync/outbox.ts 95.61% <ø> (+3.50%) ⬆️
...ages/datastore/src/sync/processors/subscription.ts 38.49% <22.22%> (+2.53%) ⬆️
packages/api-graphql/src/GraphQLAPI.ts 87.50% <50.00%> (-0.42%) ⬇️
packages/api-rest/src/RestAPI.ts 95.34% <50.00%> (-0.72%) ⬇️
...-storage-adapter/src/common/CommonSQLiteAdapter.ts 64.90% <64.90%> (ø)
packages/geo/src/Geo.ts 81.63% <65.78%> (-13.89%) ⬇️
packages/pushnotification/src/PushNotification.ts 49.07% <75.00%> (-0.24%) ⬇️
... and 65 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@katiegoines katiegoines self-assigned this Dec 6, 2021
jamesaucode
jamesaucode suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jamesaucode jamesaucode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, let me know if you any questions 😄

packages/storage/__tests__/providers/AWSS3ProviderManagedUpload-unit-test.ts Outdated Show resolved Hide resolved
packages/storage/src/providers/AWSS3ProviderManagedUpload.ts Outdated Show resolved Hide resolved
packages/storage/src/providers/AWSS3ProviderManagedUpload.ts Outdated Show resolved Hide resolved
@Legionses
Copy link

Legionses commented Feb 3, 2022 •
edited
Loading

@katiegoines @jamesaucode Hello, guys! Can u complete this fix please? Seems like error in Storage.put of multipart file is a big issue that needed to be fixed.

@Legionses Legionses mentioned this pull request Feb 3, 2022
Closed
1 task
@katiegoines
Copy link
Contributor Author

@jamesaucode - Having trouble with the cleanup. Once the upload is aborted, there is no longer an upload to find with ListParts, which is at odds with the 'error case: upload a string as body that splits in two parts but second part fails' test. Your guidance would be greatly appreciated. Thank you!

jamesaucode
jamesaucode suggested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@jamesaucode jamesaucode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 😃 just a few more changes

packages/storage/__tests__/providers/AWSS3ProviderManagedUpload-unit-test.ts Outdated Show resolved Hide resolved
packages/storage/src/providers/AWSS3ProviderManagedUpload.ts Show resolved Hide resolved
packages/storage/src/providers/AWSS3ProviderManagedUpload.ts Outdated Show resolved Hide resolved
@jamesaucode
Copy link
Contributor

jamesaucode commented Feb 9, 2022 •
edited
Loading

@jamesaucode - Having trouble with the cleanup. Once the upload is aborted, there is no longer an upload to find with ListParts, which is at odds with the 'error case: upload a string as body that splits in two parts but second part fails' test. Your guidance would be greatly appreciated. Thank you!

I think the problem is

  1. We should throw an error in .uploadParts as well
  2. In the test file, change line 309 so UploadPartsCommand resolves instead of rejecting with an error.
    Happy to sync with you offline if you need more information.

@katiegoines katiegoines requested a review from jamesaucode May 11, 2022 22:19
jamesaucode
jamesaucode approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@jamesaucode jamesaucode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@katiegoines katiegoines requested review from nickarocho, stocaaro and a team May 13, 2022 19:24
@katiegoines katiegoines merged commit 798a8f0 into aws-amplify:main May 16, 2022
stocaaro added a commit to stocaaro/amplify-js that referenced this pull request Aug 25, 2022
@stocaaro
Squashed commit of the following:
8e80da7 
commit 511751a
Author: Jon Wire <iambipedal@gmail.com>
Date:   Thu Aug 25 11:52:56 2022 -0500

    chore: fixed build, minimatch dep (aws-amplify#10261)

commit 4217e83
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue Aug 23 23:14:03 2022 +0000

    chore(release): update version.ts [ci skip]

commit da29d79
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue Aug 23 23:11:11 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.60
     - @aws-amplify/ui-components@1.9.31
     - @aws-amplify/ui-react@1.2.51
     - @aws-amplify/ui-storybook@2.0.51
     - @aws-amplify/ui-vue@1.1.45
     - @aws-amplify/analytics@5.2.18
     - @aws-amplify/api-graphql@2.3.15
     - @aws-amplify/api-rest@2.0.51
     - @aws-amplify/api@4.0.51
     - @aws-amplify/auth@4.6.4
     - aws-amplify-angular@6.0.51
     - aws-amplify-react@5.1.34
     - aws-amplify@4.3.33
     - @aws-amplify/cache@4.0.53
     - @aws-amplify/core@4.7.2
     - @aws-amplify/datastore-storage-adapter@1.3.11
     - @aws-amplify/datastore@3.12.8
     - @aws-amplify/geo@1.3.14
     - @aws-amplify/interactions@4.0.51
     - @aws-amplify/predictions@4.0.51
     - @aws-amplify/pubsub@4.5.1
     - @aws-amplify/pushnotification@4.3.30
     - @aws-amplify/storage@4.5.4
     - @aws-amplify/xr@3.0.51

commit 7d65e44
Author: Aaron S <stocaaro@stocad.com>
Date:   Tue Aug 23 17:34:16 2022 -0500

    chore: preparing release

commit 01aad60
Author: Ashwin Kumar <ashwinkumar2468@gmail.com>
Date:   Mon Aug 22 18:05:49 2022 -0700

    fix(interactions): fix addPluggable API (aws-amplify#10250)

    * fix(interactions): fix addPluggable API

    * fix(interactions): remove Add a invalid pluggable test

    Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com>

commit 2b54c1a
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Aug 18 23:50:36 2022 +0000

    chore(release): update version.ts [ci skip]

commit 2e016a6
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Aug 18 23:47:58 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.59
     - @aws-amplify/ui-components@1.9.30
     - @aws-amplify/ui-react@1.2.50
     - @aws-amplify/ui-storybook@2.0.50
     - @aws-amplify/ui-vue@1.1.44
     - @aws-amplify/analytics@5.2.17
     - @aws-amplify/api-graphql@2.3.14
     - @aws-amplify/api-rest@2.0.50
     - @aws-amplify/api@4.0.50
     - @aws-amplify/auth@4.6.3
     - aws-amplify-angular@6.0.50
     - aws-amplify-react@5.1.33
     - aws-amplify@4.3.32
     - @aws-amplify/cache@4.0.52
     - @aws-amplify/core@4.7.1
     - @aws-amplify/datastore-storage-adapter@1.3.10
     - @aws-amplify/datastore@3.12.7
     - @aws-amplify/geo@1.3.13
     - @aws-amplify/interactions@4.0.50
     - @aws-amplify/predictions@4.0.50
     - @aws-amplify/pubsub@4.5.0
     - @aws-amplify/pushnotification@4.3.29
     - @aws-amplify/storage@4.5.3
     - @aws-amplify/xr@3.0.50

commit 543014d
Author: Katie Goines <katiegoi@amazon.com>
Date:   Thu Aug 18 16:08:51 2022 -0700

    chore: preparing release

commit d6cb7f9
Author: Aaron S <94858815+stocaaro@users.noreply.github.com>
Date:   Thu Aug 18 16:39:46 2022 -0500

    fix(pubsub): Connection Ack verification bug (aws-amplify#10200)

    * fex(pubsub): Add distinct RN Reachibility implementation

    * fix(PubSub): Monitor tests

    * fix(pubsub): Connection Ack verification bug

    * Fix the test

    * fix: Add tests to cover the fixed bug

    * Update packages/pubsub/src/Providers/AWSAppSyncRealTimeProvider/index.ts

    Co-authored-by: Francisco Rodriguez <elorzafe@amazon.com>

    * Update packages/pubsub/__tests__/AWSAppSyncRealTimeProvider.test.ts

    Co-authored-by: Francisco Rodriguez <elorzafe@amazon.com>

    * Test fix

    * Fix test

    Co-authored-by: Francisco Rodriguez <elorzafe@amazon.com>

commit f28918b
Author: Aaron S <94858815+stocaaro@users.noreply.github.com>
Date:   Wed Aug 17 15:55:05 2022 -0500

    feat: PubSub Connection state tracking for MQTT and IoT providers (aws-amplify#10136)

    * feat: PubSub Connection state tracking for MQTT and IoT providers

    * fix: Add disconnect message on connection lost

commit d4c3955
Author: Ashwin Kumar <ashwinkumar2468@gmail.com>
Date:   Wed Aug 17 10:25:13 2022 -0700

    fix(interactions): fix configure default provider (aws-amplify#10215)

    * fix(interactions): fix configure default provider

    * chore: pin @types/lodash version in aws-amplify-angular

    Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com>

commit f54b645
Author: Aaron S <94858815+stocaaro@users.noreply.github.com>
Date:   Wed Aug 17 11:05:26 2022 -0500

    fix: An update to @types/lodash breaks the build - specify last working version to unblock (aws-amplify#10221)

commit 51a4598
Author: Ashwin Kumar <ashwinkumar2468@gmail.com>
Date:   Tue Aug 16 11:33:45 2022 -0700

    fix:(@aws-amplify/interactions): refactor-lex-v1 (aws-amplify#10155)

commit 0ce6b95
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue Aug 16 00:14:15 2022 +0000

    chore(release): update version.ts [ci skip]

commit d885ec2
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue Aug 16 00:11:38 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.58
     - @aws-amplify/ui-components@1.9.29
     - @aws-amplify/ui-react@1.2.49
     - @aws-amplify/ui-storybook@2.0.49
     - @aws-amplify/ui-vue@1.1.43
     - @aws-amplify/analytics@5.2.16
     - @aws-amplify/api-graphql@2.3.13
     - @aws-amplify/api-rest@2.0.49
     - @aws-amplify/api@4.0.49
     - @aws-amplify/auth@4.6.2
     - aws-amplify-angular@6.0.49
     - aws-amplify-react@5.1.32
     - aws-amplify@4.3.31
     - @aws-amplify/cache@4.0.51
     - @aws-amplify/core@4.7.0
     - @aws-amplify/datastore-storage-adapter@1.3.9
     - @aws-amplify/datastore@3.12.6
     - @aws-amplify/geo@1.3.12
     - @aws-amplify/interactions@4.0.49
     - @aws-amplify/predictions@4.0.49
     - @aws-amplify/pubsub@4.4.10
     - @aws-amplify/pushnotification@4.3.28
     - @aws-amplify/storage@4.5.2
     - @aws-amplify/xr@3.0.49

commit 80cf2c8
Author: elorzafe <elorzafe@amazon.com>
Date:   Mon Aug 15 14:49:48 2022 -0700

    chore: preparing release

commit f6e61b8
Author: elorzafe <elorzafe@amazon.com>
Date:   Mon Aug 15 14:44:29 2022 -0700

    Revert "ci: automate GitHub releases with lerna (aws-amplify#10189)"

    This reverts commit f59fa9f.

commit 74383d7
Author: Francisco Rodriguez <frodriguez.cs@gmail.com>
Date:   Thu Aug 11 14:11:06 2022 -0700

    chore: ci: Disabling integ_rn_ios_datastore_sqlite_adapter test (aws-amplify#10193)

    * Disabling integ_rn_ios_datastore_sqlite_adapter test

    * Update config.yml

commit f59fa9f
Author: Ashwin Kumar <ashwinkumar2468@gmail.com>
Date:   Thu Aug 11 09:05:50 2022 -0700

    ci: automate GitHub releases with lerna (aws-amplify#10189)

    Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com>
    Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com>

commit 92cef8a
Author: Ashika <35131273+ashika01@users.noreply.github.com>
Date:   Tue Aug 9 16:55:55 2022 -0700

    Fix: Analytics Type issue (aws-amplify#10185)

    * kinesis fix

commit 5f427f3
Author: Aaron S <94858815+stocaaro@users.noreply.github.com>
Date:   Tue Aug 9 17:45:34 2022 -0500

    fix(pubsub): Add distinct RN Reachibility implementation (aws-amplify#10175)

    * fix(pubsub): Add distinct RN Reachibility implementation

    * fix(PubSub): Fix monitor tests

commit 88f118e
Author: Ashika Kasiviswanathan Arumugakarthik <akasivis@amazon.com>
Date:   Tue Aug 9 15:04:13 2022 -0700

    Revert "kinesis fix"

    This reverts commit 763609b.

commit 4e0e22b
Author: Ashika Kasiviswanathan Arumugakarthik <akasivis@amazon.com>
Date:   Tue Aug 9 15:03:59 2022 -0700

    Revert "update personalize type to accomodate string"

    This reverts commit 9326beb.

commit 9326beb
Author: Ashika Kasiviswanathan Arumugakarthik <akasivis@amazon.com>
Date:   Tue Aug 9 14:39:19 2022 -0700

    update personalize type to accomodate string

commit 763609b
Author: Ashika Kasiviswanathan Arumugakarthik <akasivis@amazon.com>
Date:   Tue Aug 9 12:27:47 2022 -0700

    kinesis fix

commit 850788c
Author: Katie Goines <30757403+katiegoines@users.noreply.github.com>
Date:   Mon Aug 8 17:15:40 2022 -0700

    Updating config.yml to mitigate circle CI pipeline failures from outdated Xcode image (aws-amplify#10158)

    * updating config.yml for testing changes to staging

    * removing android integ tests for now

    * Update config.yml

    * removing code used for testing

    Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com>

commit 88a9ec9
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Fri Aug 5 16:31:56 2022 -0400

    fix(datastore): make di context fields private (aws-amplify#10162)

commit 360bde2
Author: Amelia Hill <49414147+amehi0index@users.noreply.github.com>
Date:   Thu Aug 4 11:49:38 2022 -0700

    feat(@aws-amplify/core): Throw Error if body attribute passed to Sign… (aws-amplify#10137)

    * feat(@aws-amplify/core): Throw Error if body attribute passed to Signer.sign()

    Co-authored-by: Ahilash Sasidharan  ahilashs@yahoo.com

    * Set space-before-function-paren to false for unit test

    * Make changes in response to PR comments

    * Make changes in response to PR comments

    * Find issue with unit tests

    * Move sign error tests into Signer-test

    * Set space-before-function-paren to false for unit test

    * Run test with space-before-function-paren set to true

    * Fix space before function error

    * Update tslint.json

    Set "space-before-function-paren" back to default setting.

    * Remove spaces before keyword "function"

    Return original formatting rule of no-spaces before "function" keyword.

    Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com>

commit dbe57a4
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Aug 3 15:14:51 2022 -0400

    Revert "Merge branch 'expo-sqlite-adapter-unit-tests' into main" (aws-amplify#10151)

    This reverts commit d8637cc, reversing
    changes made to 186349e.

commit d8637cc
Merge: 186349e a22b962
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Aug 3 14:01:36 2022 -0400

    Merge branch 'expo-sqlite-adapter-unit-tests' into main

commit 186349e
Author: aws-amplify-bot <aws@amazon.com>
Date:   Mon Aug 1 22:10:37 2022 +0000

    chore(release): update version.ts [ci skip]

commit 7c46fbc
Author: aws-amplify-bot <aws@amazon.com>
Date:   Mon Aug 1 22:08:14 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.57
     - @aws-amplify/ui-components@1.9.28
     - @aws-amplify/ui-react@1.2.48
     - @aws-amplify/ui-storybook@2.0.48
     - @aws-amplify/ui-vue@1.1.42
     - @aws-amplify/analytics@5.2.15
     - @aws-amplify/api-graphql@2.3.12
     - @aws-amplify/api-rest@2.0.48
     - @aws-amplify/api@4.0.48
     - @aws-amplify/auth@4.6.1
     - aws-amplify-angular@6.0.48
     - aws-amplify-react@5.1.31
     - aws-amplify@4.3.30
     - @aws-amplify/cache@4.0.50
     - @aws-amplify/core@4.6.1
     - @aws-amplify/datastore-storage-adapter@1.3.8
     - @aws-amplify/datastore@3.12.5
     - @aws-amplify/geo@1.3.11
     - @aws-amplify/interactions@4.0.48
     - @aws-amplify/predictions@4.0.48
     - @aws-amplify/pubsub@4.4.9
     - @aws-amplify/pushnotification@4.3.27
     - @aws-amplify/storage@4.5.1
     - @aws-amplify/xr@3.0.48

commit 53a38db
Author: elorzafe <elorzafe@amazon.com>
Date:   Mon Aug 1 14:12:11 2022 -0700

    chore: preparing release

commit 06504e6
Author: Olya Balashova <42189299+helgabalashova@users.noreply.github.com>
Date:   Mon Aug 1 13:00:52 2022 -0600

    fix(@aws-amplify/auth): fix storage bug for auto sign in value (aws-amplify#10139)

    Co-authored-by: Balashova <olybalas@98dd60782ea0.ant.amazon.com>
    Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com>

commit eb7a2c4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Jul 30 11:50:11 2022 -0400

    chore(deps): bump tzinfo from 1.2.9 to 1.2.10 in /docs (aws-amplify#10102)

commit d5cb223
Author: Aaron S <94858815+stocaaro@users.noreply.github.com>
Date:   Fri Jul 29 13:43:02 2022 -0500

    aws-amplifyGH-9824 - PubSub Connection state tracking for AppSyncRealtime (aws-amplify#10063)

    Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com>

commit 2ac9035
Author: Kha Truong <64438356+khatruong2009@users.noreply.github.com>
Date:   Fri Jul 29 11:39:07 2022 -0400

    fix(auth): Unauthenticated identity throws AuthError without user … (aws-amplify#10090)

    Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>

commit e197950
Author: Amelia Hill <49414147+amehi0index@users.noreply.github.com>
Date:   Fri Jul 29 08:19:11 2022 -0700

    Fix grammar errors and clarify testing requirements (aws-amplify#10122)

    Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>

commit fa291b3
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Jul 28 23:08:23 2022 +0000

    chore(release): update version.ts [ci skip]

commit a994818
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Jul 28 23:05:52 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.56
     - @aws-amplify/ui-components@1.9.27
     - @aws-amplify/ui-react@1.2.47
     - @aws-amplify/ui-storybook@2.0.47
     - @aws-amplify/ui-vue@1.1.41
     - @aws-amplify/analytics@5.2.14
     - @aws-amplify/api-graphql@2.3.11
     - @aws-amplify/api-rest@2.0.47
     - @aws-amplify/api@4.0.47
     - @aws-amplify/auth@4.6.0
     - aws-amplify-angular@6.0.47
     - aws-amplify-react@5.1.30
     - aws-amplify@4.3.29
     - @aws-amplify/cache@4.0.49
     - @aws-amplify/core@4.6.0
     - @aws-amplify/datastore-storage-adapter@1.3.7
     - @aws-amplify/datastore@3.12.4
     - @aws-amplify/geo@1.3.10
     - @aws-amplify/interactions@4.0.47
     - @aws-amplify/predictions@4.0.47
     - @aws-amplify/pubsub@4.4.8
     - @aws-amplify/pushnotification@4.3.26
     - @aws-amplify/storage@4.5.0
     - @aws-amplify/xr@3.0.47

commit 60c128a
Author: James Au <auchu@amazon.com>
Date:   Thu Jul 28 15:15:20 2022 -0700

    chore: preparing release

commit e54617f
Author: Olya Balashova <42189299+helgabalashova@users.noreply.github.com>
Date:   Thu Jul 28 13:50:58 2022 -0600

    feat(@aws-amplify/auth): Auto sign in after sign up (aws-amplify#10126)

    Fixes: aws-amplify#6320 aws-amplify#3882 aws-amplify#3631 aws-amplify#6018

    Co-authored-by: Balashova <helgabalashova>
    Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com>

commit 366c32e
Author: Venkata Ramyasri Kota <34170013+kvramyasri7@users.noreply.github.com>
Date:   Thu Jul 28 07:23:33 2022 -0700

    feat(@aws-amplify/storage): Access all files from S3 with List API (aws-amplify#10095)

    Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>

commit 0729e68
Author: Amelia Hill <49414147+amehi0index@users.noreply.github.com>
Date:   Wed Jul 27 09:41:11 2022 -0700

    Fix typo in contributing guide (aws-amplify#10104)

commit 63fcc69
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Jul 21 23:19:11 2022 +0000

    chore(release): update version.ts [ci skip]

commit e20a146
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Jul 21 23:16:41 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.55
     - @aws-amplify/ui-components@1.9.26
     - @aws-amplify/ui-react@1.2.46
     - @aws-amplify/ui-storybook@2.0.46
     - @aws-amplify/ui-vue@1.1.40
     - @aws-amplify/analytics@5.2.13
     - @aws-amplify/api-graphql@2.3.10
     - @aws-amplify/api-rest@2.0.46
     - @aws-amplify/api@4.0.46
     - @aws-amplify/auth@4.5.10
     - aws-amplify-angular@6.0.46
     - aws-amplify-react@5.1.29
     - aws-amplify@4.3.28
     - @aws-amplify/cache@4.0.48
     - @aws-amplify/core@4.5.10
     - @aws-amplify/datastore-storage-adapter@1.3.6
     - @aws-amplify/datastore@3.12.3
     - @aws-amplify/geo@1.3.9
     - @aws-amplify/interactions@4.0.46
     - @aws-amplify/predictions@4.0.46
     - @aws-amplify/pubsub@4.4.7
     - @aws-amplify/pushnotification@4.3.25
     - @aws-amplify/storage@4.4.29
     - @aws-amplify/xr@3.0.46

commit 9080bed
Author: elorzafe <elorzafe@amazon.com>
Date:   Thu Jul 21 15:27:34 2022 -0700

    chore: preparing release

commit b7ad126
Author: James Au <40404256+jamesaucode@users.noreply.github.com>
Date:   Tue Jul 19 19:03:02 2022 -0700

    fix: Update AmazonPersonalizeProvider Analytics typings (aws-amplify#10076)

commit a10d920
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Tue Jul 19 15:30:40 2022 -0400

    fix: preserve ssr context when using DataStore (aws-amplify#10088)

commit dfe6461
Author: David McAfee <mcafd@amazon.com>
Date:   Mon Jul 18 18:07:36 2022 -0400

    Update .github/CODEOWNERS

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

commit da4a927
Author: David McAfee <mcafd@amazon.com>
Date:   Mon Jul 18 17:15:42 2022 -0400

    chore(data): update CODEOWNERS file

commit 633a839
Author: erinleigh90 <106691284+erinleigh90@users.noreply.github.com>
Date:   Mon Jul 18 15:18:50 2022 -0700

    Datastore/feat user agent suffix (aws-amplify#10086)

    * Adds suffix to user agent for calls to API initiated by DataStore

    * Attempts to fix first half of user agent not being sent

    * Makes setting of user agent header more concise

    * Moves appending of suffix to user agent to core library

    * Moves user agent suffix constant to common util in datastore

    * Removes unused import

    * Unit test for api-graphql

    * Pulls in user agent suffix from datastore utils class

    * Adds unit test for getAmplifyUserAgent with and without content

    * Fixes issue found while testing, line too long.

    * Adds test for DataStore mutation.ts

    * Tests user agent suffix in datastore sync

    * Adds user agent suffix assertion to subscription test

    * Fixes variable declaration: const instead of let

    * Removes leftover lines of code from testing objectContains

    * Removes code style changes unrelated to user agent suffix

    * Removes code style changes unrelated to user agent suffix

    * Removes unnecessary null value option for userAgentSuffix - undefined is sufficient

    * Replaces imports from lib-esm

    * Replaces hard-coded string in assertion with constant from util file

    * Moves var declaration under import

    * Makes test method names more descriptive

    Co-authored-by: Erin Beal <erinleig@amazon.com>

commit 8e49b0d
Author: Michael Law <1365977+lawmicha@users.noreply.github.com>
Date:   Wed Jul 13 10:28:29 2022 -0400

    chore(datastore): Add schema-drift integration test (aws-amplify#10077)

commit 0992704
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Mon Jul 11 14:00:13 2022 -0600

    chore: add dpilch to datastore codeowners (aws-amplify#10031)

commit f6e2ca2
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Jul 7 22:44:30 2022 +0000

    chore(release): update version.ts [ci skip]

commit d3c993f
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu Jul 7 22:42:02 2022 +0000

    chore(release): Publish [ci skip]

     - amazon-cognito-identity-js@5.2.10
     - @aws-amplify/ui-angular@1.0.54
     - @aws-amplify/ui-components@1.9.25
     - @aws-amplify/ui-react@1.2.45
     - @aws-amplify/ui-storybook@2.0.45
     - @aws-amplify/ui-vue@1.1.39
     - @aws-amplify/analytics@5.2.12
     - @aws-amplify/api-graphql@2.3.9
     - @aws-amplify/api-rest@2.0.45
     - @aws-amplify/api@4.0.45
     - @aws-amplify/auth@4.5.9
     - aws-amplify-angular@6.0.45
     - aws-amplify-react@5.1.28
     - aws-amplify-vue@2.1.7
     - aws-amplify@4.3.27
     - @aws-amplify/cache@4.0.47
     - @aws-amplify/core@4.5.9
     - @aws-amplify/datastore-storage-adapter@1.3.5
     - @aws-amplify/datastore@3.12.2
     - @aws-amplify/geo@1.3.8
     - @aws-amplify/interactions@4.0.45
     - @aws-amplify/predictions@4.0.45
     - @aws-amplify/pubsub@4.4.6
     - @aws-amplify/pushnotification@4.3.24
     - @aws-amplify/storage@4.4.28
     - @aws-amplify/xr@3.0.45

commit 704dfb3
Author: Aaron S <stocaaro@stocad.com>
Date:   Thu Jul 7 16:34:05 2022 -0500

    chore: preparing release

commit de0441b
Author: Satana Charuwichitratana <satana.charu@gmail.com>
Date:   Wed Jul 6 07:22:29 2022 +0700

    fix(amazon-cognito-identity-js): Missing cognito user challenge name … (aws-amplify#10047)

    * fix(amazon-cognito-identity-js): Missing cognito user challenge name type

    * fix(type): Fix other functions reported in aws-amplify#6974

    * Update Auth units with correct ChallengeName

    Co-authored-by: elorzafe <elorzafe@amazon.com>

commit 870ec87
Author: James Au <40404256+jamesaucode@users.noreply.github.com>
Date:   Fri Jul 1 15:18:35 2022 -0700

    fix: pin vue version (aws-amplify#10052)

commit b454b5c
Author: Caleb Pollman <cpollman@amazon.com>
Date:   Thu Jun 30 14:23:55 2022 -0700

    chore(CODEOWNERS): update geo category codeowners (aws-amplify#10048)

commit 3dd9035
Author: Chris F <5827964+cshfang@users.noreply.github.com>
Date:   Wed Jun 29 12:25:15 2022 -0700

    fix(analytics): Buffer limit should be adhered to (aws-amplify#10015)

    Co-authored-by: Chris Fang <chrfang@amazon.com>

commit 11b537c
Author: James Au <40404256+jamesaucode@users.noreply.github.com>
Date:   Wed Jun 29 11:31:34 2022 -0700

    fix: Update Auth to import JS using named export  (aws-amplify#10033)

    Imports specific functions instead of the whole JS module to improve bundle size

commit fb1f02c
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Tue Jun 28 15:18:18 2022 -0600

    fix: decrease error handler verbosity on self recovering errors (aws-amplify#10030)

    restore warning message

commit 9cca114
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Thu Jun 23 16:08:52 2022 -0400

    ci: canaries rn workaround (aws-amplify#10020)

commit 5e82649
Author: aws-amplify-bot <aws@amazon.com>
Date:   Sat Jun 18 02:53:49 2022 +0000

    chore(release): update version.ts [ci skip]

commit f206bf6
Author: aws-amplify-bot <aws@amazon.com>
Date:   Sat Jun 18 02:51:33 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.53
     - @aws-amplify/ui-components@1.9.24
     - @aws-amplify/ui-react@1.2.44
     - @aws-amplify/ui-storybook@2.0.44
     - @aws-amplify/ui-vue@1.1.38
     - @aws-amplify/analytics@5.2.11
     - @aws-amplify/api-graphql@2.3.8
     - @aws-amplify/api-rest@2.0.44
     - @aws-amplify/api@4.0.44
     - @aws-amplify/auth@4.5.8
     - aws-amplify-angular@6.0.44
     - aws-amplify-react@5.1.27
     - aws-amplify@4.3.26
     - @aws-amplify/cache@4.0.46
     - @aws-amplify/core@4.5.8
     - @aws-amplify/datastore-storage-adapter@1.3.4
     - @aws-amplify/datastore@3.12.1
     - @aws-amplify/geo@1.3.7
     - @aws-amplify/interactions@4.0.44
     - @aws-amplify/predictions@4.0.44
     - @aws-amplify/pubsub@4.4.5
     - @aws-amplify/pushnotification@4.3.23
     - @aws-amplify/storage@4.4.27
     - @aws-amplify/xr@3.0.44

commit b339298
Author: David McAfee <mcafd@amazon.com>
Date:   Fri Jun 17 19:20:23 2022 -0700

    chore: preparing release

commit eb73ad7
Author: David McAfee <mcafd@amazon.com>
Date:   Fri Jun 17 18:32:11 2022 -0700

    Revert "fix: decrease error handler verbosity on self recovering errors (aws-amplify#9987)" (aws-amplify#10004)

    This reverts commit 67ccf09.

commit 8fb868f
Author: David McAfee <mcafd@amazon.com>
Date:   Fri Jun 17 17:16:28 2022 -0700

    fix: update geo integ tests to use chrome due to issue with CRA Jest dependency when using Node 16.5.x (aws-amplify#10003)

commit 8b6728d
Author: Jon Wire <iambipedal@gmail.com>
Date:   Fri Jun 17 16:18:41 2022 -0500

    inc timeouts to stabilize observequery unit tests which are flakey in circleci

commit b5c6825
Author: David McAfee <mcafd@amazon.com>
Date:   Fri Jun 17 12:49:55 2022 -0700

    fix: remove comments

commit 67316d7
Author: David McAfee <mcafd@amazon.com>
Date:   Thu Jun 16 15:29:29 2022 -0700

    fix: update axios

commit 67ccf09
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Fri Jun 17 11:05:50 2022 -0600

    fix: decrease error handler verbosity on self recovering errors (aws-amplify#9987)

    * fix: decrease error handler verbosity on self recovering errors

    * style: remove unused vars

    * test: increase test coverage on auth mode retry error handler

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

commit e6e7b13
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Thu Jun 16 13:08:40 2022 -0400

    ci: canaries - improve retry command (aws-amplify#9996)

commit 0fb173d
Author: aws-amplify-bot <aws@amazon.com>
Date:   Wed Jun 15 22:50:19 2022 +0000

    chore(release): update version.ts [ci skip]

commit d436444
Author: aws-amplify-bot <aws@amazon.com>
Date:   Wed Jun 15 22:47:34 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.52
     - @aws-amplify/ui-components@1.9.23
     - @aws-amplify/ui-react@1.2.43
     - @aws-amplify/ui-storybook@2.0.43
     - @aws-amplify/ui-vue@1.1.37
     - @aws-amplify/analytics@5.2.10
     - @aws-amplify/api-graphql@2.3.7
     - @aws-amplify/api-rest@2.0.43
     - @aws-amplify/api@4.0.43
     - @aws-amplify/auth@4.5.7
     - aws-amplify-angular@6.0.43
     - aws-amplify-react-native@6.0.5
     - aws-amplify-react@5.1.26
     - aws-amplify@4.3.25
     - @aws-amplify/cache@4.0.45
     - @aws-amplify/core@4.5.7
     - @aws-amplify/datastore-storage-adapter@1.3.3
     - @aws-amplify/datastore@3.12.0
     - @aws-amplify/geo@1.3.6
     - @aws-amplify/interactions@4.0.43
     - @aws-amplify/predictions@4.0.43
     - @aws-amplify/pubsub@4.4.4
     - @aws-amplify/pushnotification@4.3.22
     - @aws-amplify/storage@4.4.26
     - @aws-amplify/xr@3.0.43

commit 97f98fc
Author: David McAfee <mcafd@amazon.com>
Date:   Wed Jun 15 14:44:13 2022 -0700

    chore: preparing release

commit 88b6a1e
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Tue Jun 14 15:32:34 2022 -0400

    fix: Add module declaration files for datastore-storage-adapter (aws-amplify#9922)

    * Add module declaration files

    * Update the module declaration to index files

    Co-authored-by: Nick Arocho <16296496+nickarocho@users.noreply.github.com>

commit ca2a11b
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon Jun 13 16:00:11 2022 -0500

    fix(@aws-amplify/datastore): adds missing fields to items sent through observe/observeQuery (aws-amplify#9973)

    * manual rebase: add missing fields to items sent through observe/observequery

    * added testing to ensure outbox only contains expected fields

    * removed cruft; removed explicit check for undef mutation field

commit d5dd9cb
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Mon Jun 13 11:03:21 2022 -0600

    fix: merge patches for consecutive copyOf (aws-amplify#9936)

    * test: add unit test for consecutive copyOf

    * fix: merge patches for consecutive copyOf

commit bcb7fa6
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Fri Jun 10 16:00:15 2022 -0400

    ci: revert canaries change (aws-amplify#9980)

commit e9cb92c
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Fri Jun 10 13:21:22 2022 -0400

    ci: correct run-with-retry command (aws-amplify#9978)

commit d1356b1
Author: Jon Wire <iambipedal@gmail.com>
Date:   Thu Jun 9 15:37:29 2022 -0500

    fix(@aws-amplify/datastore): fixes observeQuery not removing newly-filtered items from snapshot (aws-amplify#9879)

    * test: added observeQuery tests; one skipped, intended to show correct behavior ahead of fix

    * working fix; still needs cleanup

    * a little cleanup

    * comment, docstring updates

    * more docstrings

    * fixed formatting in docstring

    * replaced naughty test pollution solution with better one

    * added test cases for delete

commit 3a27096
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Thu Jun 9 11:59:06 2022 -0600

    feat(datastore): add error maps for error handler (aws-amplify#9918)

    * feat(datastore): add error map for newly required field

    * feat(datastore): add error map for unauthorized create

    * feat(datastore): add connection timeout error map

    * feat(datastore): add server error map

    * docs: add comment on error map util

    * test: add error map unit tests

commit 61d60c7
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Wed Jun 8 18:28:26 2022 -0400

    ci: restore xcode version for macos executor (aws-amplify#9974)

commit 08b6c0c
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Wed Jun 8 16:38:44 2022 -0400

    ci: add canaries workflow (aws-amplify#9953)

commit bc9b710
Author: Nick Arocho <16296496+nickarocho@users.noreply.github.com>
Date:   Wed Jun 8 12:34:40 2022 -0700

    chore(deps): bump dexie from 3.2.0 to 3.2.2 in DataStore (aws-amplify#9960)

commit 1a5018a
Author: Shane Laymance <shane.laymance@gmail.com>
Date:   Tue Jun 7 10:02:04 2022 -0700

    Add unit tests for validateGeofenceId (aws-amplify#9964)

commit e7220da
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon Jun 6 12:58:02 2022 -0500

    resolve error-stack-parser, which introduced a build-blocked bug after 2.0.6 (aws-amplify#9963)

commit e52e927
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jun 3 12:14:45 2022 -0700

    chore(deps): bump nokogiri from 1.13.4 to 1.13.6 in /docs (aws-amplify#9916)

    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.4 to 1.13.6.
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.13.4...v1.13.6)

    ---
    updated-dependencies:
    - dependency-name: nokogiri
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Jon Wire <iambipedal@gmail.com>
    Co-authored-by: Nick Arocho <16296496+nickarocho@users.noreply.github.com>

commit 94813a9
Author: Ben Sewell <ben@calc-i.com>
Date:   Wed Jun 1 16:14:30 2022 +0100

    fix(aws-amplify-react-native): set Resend Code enabled/disabled from current username value (aws-amplify#9767)

commit 9e3792f
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue May 24 02:40:49 2022 +0000

    chore(release): update version.ts [ci skip]

commit 78a6b54
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue May 24 02:38:08 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.51
     - @aws-amplify/ui-components@1.9.22
     - @aws-amplify/ui-react@1.2.42
     - @aws-amplify/ui-storybook@2.0.42
     - @aws-amplify/ui-vue@1.1.36
     - @aws-amplify/analytics@5.2.9
     - @aws-amplify/api-graphql@2.3.6
     - @aws-amplify/api-rest@2.0.42
     - @aws-amplify/api@4.0.42
     - @aws-amplify/auth@4.5.6
     - aws-amplify-angular@6.0.42
     - aws-amplify-react@5.1.25
     - aws-amplify@4.3.24
     - @aws-amplify/cache@4.0.44
     - @aws-amplify/core@4.5.6
     - @aws-amplify/datastore-storage-adapter@1.3.2
     - @aws-amplify/datastore@3.11.3
     - @aws-amplify/geo@1.3.5
     - @aws-amplify/interactions@4.0.42
     - @aws-amplify/predictions@4.0.42
     - @aws-amplify/pubsub@4.4.3
     - @aws-amplify/pushnotification@4.3.21
     - @aws-amplify/storage@4.4.25
     - @aws-amplify/xr@3.0.42

commit 3490c1a
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon May 23 20:52:00 2022 -0500

    chore: preparing release

commit 40019a6
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon May 23 20:48:10 2022 -0500

    removed integ_duplicate_packages test dep

commit cdc385d
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon May 23 20:18:58 2022 -0500

    chore: preparing release

commit 5f1eb2a
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon May 23 20:18:21 2022 -0500

    updating analytics copyright date

commit e5c0431
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon May 23 20:06:58 2022 -0500

    chore: preparing release

commit b796a35
Author: aws-amplify-bot <aws@amazon.com>
Date:   Mon May 23 21:59:44 2022 +0000

    chore(release): update version.ts [ci skip]

commit e5858bc
Author: aws-amplify-bot <aws@amazon.com>
Date:   Mon May 23 21:57:08 2022 +0000

    chore(release): Publish [ci skip]

     - amazon-cognito-identity-js@5.2.9
     - @aws-amplify/ui-angular@1.0.50
     - @aws-amplify/ui-components@1.9.21
     - @aws-amplify/ui-react@1.2.41
     - @aws-amplify/ui-storybook@2.0.41
     - @aws-amplify/ui-vue@1.1.35
     - @aws-amplify/analytics@5.2.8
     - @aws-amplify/api-graphql@2.3.5
     - @aws-amplify/api-rest@2.0.41
     - @aws-amplify/api@4.0.41
     - @aws-amplify/auth@4.5.5
     - aws-amplify-angular@6.0.41
     - aws-amplify-react@5.1.24
     - aws-amplify@4.3.23
     - @aws-amplify/cache@4.0.43
     - @aws-amplify/core@4.5.5
     - @aws-amplify/datastore-storage-adapter@1.3.1
     - @aws-amplify/datastore@3.11.2
     - @aws-amplify/geo@1.3.4
     - @aws-amplify/interactions@4.0.41
     - @aws-amplify/predictions@4.0.41
     - @aws-amplify/pubsub@4.4.2
     - @aws-amplify/pushnotification@4.3.20
     - @aws-amplify/storage@4.4.24
     - @aws-amplify/xr@3.0.41

commit 1b794b8
Author: Jon Wire <iambipedal@gmail.com>
Date:   Mon May 23 16:19:47 2022 -0500

    chore: preparing release

commit 00923cf
Author: Jon Wire <iambipedal@gmail.com>
Date:   Fri May 20 15:55:34 2022 -0500

    fix(@aws-amplify/datastore-storage-adapter): remove extra, invalid sqlite mutations again (aws-amplify#9921)

    * testing expanded, refixed sqlite adapter

    * ported sqlite adapter test expansion to indexeddbadapter tests

    * working on making all adapter tests share common test script

    * shared tests working in both datastore and datastore-storage-adapter

    * moved and incorporated record adder helper in common adapter tests

    * cleanup cruft

    * cleaned up crufty lib include

commit 7656bc8
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Tue May 17 11:53:57 2022 -0600

    refactor(datastore): add stub error maps (aws-amplify#9878)

commit 08e01b1
Author: Luis Carlos <63477093+luis737@users.noreply.github.com>
Date:   Mon May 16 18:24:22 2022 -0100

    fix: docs for amazon-cognito-identity-js (aws-amplify#9909)

    Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com>

commit 798a8f0
Author: Katie Goines <30757403+katiegoines@users.noreply.github.com>
Date:   Mon May 16 11:10:21 2022 -0700

    fix(@aws-amplify/storage): throw error if all upload parts complete but upload cannot be finished (aws-amplify#9317)

    * fix(@aws-amplify/storage): throw error if all upload parts complete but upload cannot be finished

    * fix(@aws-amplify/storage): updating tests

    * fix(@aws-amplify/storage): fixed unit tests

    * fix(@aws-amplify/storage): revert prettification

    * fix(@aws-amplify/storage): revert prettification

    * fix(@aws-amplify/storage): revert prettification

    * working on tests

    * response to auchu@ feedback

    * quick test fix

    * fix(storage): reverted trial changes

    * fix(storage):  throw error if all upload parts complete but upload cannot be finished

    * fix(storage): resolving merge conflicts from main

    * fix(storage): adjusting tests

    * fix: Remove cancel variable entirely

    Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>

commit 29a40cc
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu May 12 22:09:50 2022 +0000

    chore(release): update version.ts [ci skip]

commit 926e55a
Author: aws-amplify-bot <aws@amazon.com>
Date:   Thu May 12 22:07:32 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.49
     - @aws-amplify/ui-components@1.9.20
     - @aws-amplify/ui-react@1.2.40
     - @aws-amplify/ui-storybook@2.0.40
     - @aws-amplify/ui-vue@1.1.34
     - @aws-amplify/analytics@5.2.7
     - @aws-amplify/api-graphql@2.3.4
     - @aws-amplify/api-rest@2.0.40
     - @aws-amplify/api@4.0.40
     - @aws-amplify/auth@4.5.4
     - aws-amplify-angular@6.0.40
     - aws-amplify-react@5.1.23
     - aws-amplify@4.3.22
     - @aws-amplify/cache@4.0.42
     - @aws-amplify/core@4.5.4
     - @aws-amplify/datastore-storage-adapter@1.3.0
     - @aws-amplify/datastore@3.11.1
     - @aws-amplify/geo@1.3.3
     - @aws-amplify/interactions@4.0.40
     - @aws-amplify/predictions@4.0.40
     - @aws-amplify/pubsub@4.4.1
     - @aws-amplify/pushnotification@4.3.19
     - @aws-amplify/storage@4.4.23
     - @aws-amplify/xr@3.0.40

commit 98706a7
Author: Katie Goines <katiegoi@amazon.com>
Date:   Thu May 12 14:20:46 2022 -0700

    chore: preparing release

commit a63f0ee
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Thu May 12 08:59:30 2022 -0600

    fix: add error for when schema is not initialized (aws-amplify#9874)

    * fix: add error for when schema is not initialized

    * chore: change warning to error

    * refactor: remove schemaInitialized variable

commit a9ae27f
Author: James Au <40404256+jamesaucode@users.noreply.github.com>
Date:   Tue May 10 10:37:51 2022 -0700

    fix(@aws-amplify/api): graphql API.cancel fix (aws-amplify#9578)

commit f72e3df
Author: Jon Wire <iambipedal@gmail.com>
Date:   Fri May 6 14:40:57 2022 -0500

    chore: remove arkam from codeowners (aws-amplify#9880)

commit a8ed3c2
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Fri May 6 13:38:22 2022 -0400

    feat: Added ExpoSQLiteAdapter and Code Sharing for common files (aws-amplify#9581)

    * Added ExpoSQLiteAdapter and Code Sharing for common files

    * changes to naming and updates regarding feedback from Draft PR

    * remove local changes from .vscode and package.json

    * Apply feedback from Caleb's and Chris's Code Review

    * remove unused imports and warn about db errors

    * added @types/react-native-sqlite-storage as devDependency for improved typing

    * Apply feedback from Chris and fix the initial sync problem

    * re-order dependencies

    * Addressed feedback from Chris

    * Assign any type to Result from SQLResultSetRowList as defined in expo-sqlite docs

    * Seperate entrypoint for ExpoSQLiteAdapter

    * Apply feedback from Caleb & Chris, Remove unused variable and separate entrypoints

    * Remove unnecesary async, alphabetic order for import statements and npm packages, single transaction for batchSave

    * remove unnecessary casting

    * Removed version, size and description args from openDatabase as they are not being used

    * Removed version, size and description args from openDatabase and moved entrypoint files in folders

    * Use similar export patterns across SQLiteAdapter and ExpoSQLiteAdapter

    * log additional information as warning when transaction promise rejects

    * Remove bug from batchSave that prevented the catch block execution

    * Fix lint issues

    * added back expo-file-system, accidentally removed it

    * Update adapter constructor name to CommonSQLiteAdapter

    * default export for adapter, symmetric export pattern across adapters and different entrypoints

    * export commonly used constants from common/constants

    * Update import statement and remove [] as a param from test. SQlite does not support arrays

    Co-authored-by: Caleb Pollman <cpollman@amazon.com>

commit 8096cd5
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue May 3 20:38:07 2022 +0000

    chore(release): update version.ts [ci skip]

commit ce9c595
Author: aws-amplify-bot <aws@amazon.com>
Date:   Tue May 3 20:35:31 2022 +0000

    chore(release): Publish [ci skip]

     - @aws-amplify/ui-angular@1.0.48
     - @aws-amplify/ui-components@1.9.19
     - @aws-amplify/ui-react@1.2.39
     - @aws-amplify/ui-storybook@2.0.39
     - @aws-amplify/ui-vue@1.1.33
     - @aws-amplify/analytics@5.2.6
     - @aws-amplify/api-graphql@2.3.3
     - @aws-amplify/api-rest@2.0.39
     - @aws-amplify/api@4.0.39
     - @aws-amplify/auth@4.5.3
     - aws-amplify-angular@6.0.39
     - aws-amplify-react@5.1.22
     - aws-amplify@4.3.21
     - @aws-amplify/cache@4.0.41
     - @aws-amplify/core@4.5.3
     - @aws-amplify/datastore-storage-adapter@1.2.13
     - @aws-amplify/datastore@3.11.0
     - @aws-amplify/geo@1.3.2
     - @aws-amplify/interactions@4.0.39
     - @aws-amplify/predictions@4.0.39
     - @aws-amplify/pubsub@4.4.0
     - @aws-amplify/pushnotification@4.3.18
     - @aws-amplify/storage@4.4.22
     - @aws-amplify/xr@3.0.39

commit fa8d008
Author: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Date:   Tue May 3 16:00:46 2022 -0400

    chore: preparing release

commit cb245af
Author: thaddmt <68032955+thaddmt@users.noreply.github.com>
Date:   Tue May 3 10:13:22 2022 -0700

    chore(geo): reduce number of integ spec cases (aws-amplify#9862)

commit 6ae8d10
Author: Dane Pilcher <dppilche@amazon.com>
Date:   Tue May 3 10:13:05 2022 -0600

    feat: rework error handler (aws-amplify#9861)

    * feat: add new error handler

    * feat: remove error handler return type

    * Update packages/datastore/src/sync/processors/sync.ts

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

    * Update packages/datastore/src/sync/processors/mutation.ts

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

    * Update packages/datastore/src/sync/processors/subscription.ts

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

    * Update packages/datastore/src/types.ts

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

    * Update packages/datastore/src/sync/utils.ts

    Co-authored-by: Jon Wire <iambipedal@gmail.com>

    * style: move error map

    * fix: move subscription error handler up

    * style: fix tslint

    * fix: typo

    * fix: make error handler required in sync processors

    Co-authored-by: ArkamJ <arkamj@amazon.com>
    Co-authored-by: Jon Wire <iambipedal@gmail.com>

commit a22b962
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Apr 28 12:39:25 2022 -0400

    Address feedback from Chris

commit dd2e1c8
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Apr 14 13:34:08 2022 -0400

    Add more tests and change the location

commit 634433a
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Mon Apr 4 13:29:17 2022 -0400

    Add initial unit tests for ExpoSQLiteAdapter

commit 5fac5e8
Merge: 5b19467 611cc7b
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Tue Mar 29 15:09:35 2022 -0400

    Merge branch 'expo-sqlite-adapter-codesharing' of github.com:chintannp/amplify-js into expo-sqlite-adapter-codesharing

commit 5b19467
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Mon Mar 28 11:42:26 2022 -0400

    Removed version, size and description args from openDatabase and moved entrypoint files in folders

commit 611cc7b
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Mon Mar 28 11:42:26 2022 -0400

    Removed version, size and description args from openDatabase as they are not being used

commit cb1be23
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Mar 17 15:29:01 2022 -0400

    remove unnecessary casting

commit 980c873
Merge: 3b98401 b65d511
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 16 15:34:21 2022 -0400

    Add missing , to package.json

commit 3b98401
Merge: 55c76e6 0de2768
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 16 15:30:05 2022 -0400

    Merge branch 'main' into expo-sqlite-adapter-codesharing

commit b65d511
Merge: 55c76e6 0de2768
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 16 15:30:05 2022 -0400

    Merge branch 'main' into expo-sqlite-adapter-codesharing

commit 55c76e6
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 16 15:18:37 2022 -0400

    Remove unnecesary async, alphabetic order for import statements and npm packages, single transaction for batchSave

commit 0145017
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Mar 10 12:42:08 2022 -0500

    Apply feedback from Caleb & Chris, Remove unused variable and separate entrypoints

commit 26bed3c
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Mon Mar 7 12:35:45 2022 -0500

    Seperate entrypoint for ExpoSQLiteAdapter

commit 07f16c0
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Mar 3 12:58:57 2022 -0500

    Assign any type to Result from SQLResultSetRowList as defined in expo-sqlite docs

commit 9f3b666
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Mar 3 12:38:14 2022 -0500

    Addressed feedback from Chris

commit e478987
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 2 12:38:28 2022 -0500

    re-order dependencies

commit 910fe94
Merge: ceb5c8e 6117e71
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 2 12:36:11 2022 -0500

    Merge branch 'main' into expo-sqlite-adapter-codesharing

commit ceb5c8e
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Mar 2 12:24:13 2022 -0500

    Apply feedback from Chris and fix the initial sync problem

commit 1ec72f3
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Feb 17 12:17:44 2022 -0500

    added @types/react-native-sqlite-storage as devDependency for improved typing

commit 47f8274
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Thu Feb 17 09:59:53 2022 -0500

    remove unused imports and warn about db errors

commit 6a76400
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Wed Feb 16 17:27:33 2022 -0500

    Apply feedback from Caleb's and Chris's Code Review

commit 9f318ea
Merge: c635f3e 9a52c2b
Author: Caleb Pollman <cpollman@amazon.com>
Date:   Fri Feb 11 17:08:45 2022 -0800

    Merge branch 'main' into expo-sqlite-adapter-codesharing

commit c635f3e
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Fri Feb 11 17:59:34 2022 -0500

    remove local changes from .vscode and package.json

commit b212dd3
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Fri Feb 11 17:55:48 2022 -0500

    changes to naming and updates regarding feedback from Draft PR

commit 3560af9
Author: chintannp <88387035+chintannp@users.noreply.github.com>
Date:   Fri Feb 11 13:26:30 2022 -0500

    Added ExpoSQLiteAdapter and Code Sharing for common files
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server amplify-help forum.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stocaaro stocaaro stocaaro approved these changes

@jamesaucode jamesaucode jamesaucode approved these changes

@nickarocho nickarocho Awaiting requested review from nickarocho

Assignees

@katiegoines katiegoines

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@katiegoines @codecov-commenter @Legionses @jamesaucode @stocaaro