-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@aws-amplify/datastore): fixes observeQuery not removing newly-filtered items from snapshot #9879
Merged
Merged
fix(@aws-amplify/datastore): fixes observeQuery not removing newly-filtered items from snapshot #9879
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f360a59
test: added observeQuery tests; one skipped, intended to show correct…
svidgen 6daaf3c
Merge branch 'main' into gh-9325
svidgen bd01398
Merge branch 'main' into gh-9325
svidgen 9c239b4
working fix; still needs cleanup
svidgen 262f5e1
a little cleanup
svidgen 1c07f87
comment, docstring updates
svidgen 43899d1
more docstrings
svidgen ace3360
fixed formatting in docstring
svidgen ffaa06b
Merge branch 'main' into gh-9325
svidgen eadb5fc
replaced naughty test pollution solution with better one
svidgen 99be132
Merge branch 'main' into gh-9325
svidgen cd09343
added test cases for delete
svidgen 6257e51
Merge branch 'main' into gh-9325
svidgen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid this naughtiness by using different models for each test?
It may make the test more verbose but will make them more isolated from each other