Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSAuthFetchSessionTask doesn't redact all keys #3470

Closed
jostster opened this issue Jan 12, 2024 · 2 comments
Closed

AWSAuthFetchSessionTask doesn't redact all keys #3470

jostster opened this issue Jan 12, 2024 · 2 comments
Labels
auth Issues related to the Auth category question General question

Comments

@jostster
Copy link

Describe the bug

Looking in Cloudwatch at the AWSAuthFetchSessionTask.fetchSessionAPI result, I see that the first outer properties of accessKey, sessionToken, and secretAccessKey are redacted, however in the line below the redacted, it shows the full properties and values.

Steps To Reproduce

Steps to reproduce the behavior:
1. Enable logging with default level `INFO`
2. Login with cognito or launch app with guest enabled and view the logs.
3. Look for the `AWSAuthFetchSessionTask` results and you will see the first properties are redacted but the exact same ones in the lines below are not.

Expected behavior

All references to those values should be redacted.

Amplify Framework Version

2.25.3

Amplify Categories

Auth

Dependency manager

Swift PM

Swift version

5.9.2

CLI version

12.10.1

Xcode version

15.2

Relevant log output

<details>
<summary>Log Messages</summary>


INSERT LOG MESSAGES HERE
```

Is this a regression?

No

Regression additional context

No response

Platforms

iOS

OS Version

iOS 17.2

Device

iPhone 15 Pro

Specific to simulators

No

Additional context

No response

@harsh62 harsh62 added auth Issues related to the Auth category question General question labels Jan 15, 2024
@harsh62
Copy link
Member

harsh62 commented Jan 15, 2024

The fix has been merged and released.

@harsh62 harsh62 closed this as completed Jan 15, 2024
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Issues related to the Auth category question General question
Projects
None yet
Development

No branches or pull requests

2 participants