Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Auth): properly redacting session information #3472

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jan 15, 2024

Issue #

#3470

Description

Removing the prettify function which is not conforming to the redaction done in the debug dictionary.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner January 15, 2024 16:14
lawmicha
lawmicha previously approved these changes Jan 15, 2024
Copy link
Member

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, with non-blocking comment

@harsh62 harsh62 merged commit f9b02de into main Jan 15, 2024
78 checks passed
@harsh62 harsh62 deleted the fix/redaction-issue branch January 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants