Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): adding support for email mfa #3862

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Sep 13, 2024

Description

The PR aims to add support for Email MFA that has been released by Cognito.

Depends upon the Swift SDK being upgraded to the latest version with Email MFA models:

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner September 13, 2024 16:00
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.15%. Comparing base (1ec20d0) to head (fedf82a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...in/Actions/SignIn/InitializeResolveChallenge.swift 72.09% 12 Missing ⚠️
...es/AWSCognitoAuthPlugin/Models/MFAPreference.swift 0.00% 10 Missing ⚠️
...solvers/SignIn/SignInChallengeState+Resolver.swift 81.25% 3 Missing ⚠️
...ignIn/SoftwareTokenSetup/InitializeTOTPSetup.swift 0.00% 2 Missing ⚠️
.../Actions/SignIn/SoftwareTokenSetup/SetUpTOTP.swift 0.00% 2 Missing ⚠️
...hPlugin/Actions/SignIn/VerifySignInChallenge.swift 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
+ Coverage   68.14%   68.15%   +0.01%     
==========================================
  Files        1085     1085              
  Lines       37992    38062      +70     
==========================================
+ Hits        25889    25941      +52     
- Misses      12103    12121      +18     
Flag Coverage Δ
API_plugin_unit_test 69.32% <ø> (ø)
AWSPluginsCore 68.53% <ø> (ø)
Amplify 47.10% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.32% <75.00%> (-0.08%) ⬇️
DataStore_plugin_unit_test 81.29% <ø> (+0.05%) ⬆️
Geo_plugin_unit_test 72.06% <ø> (ø)
Logging_plugin_unit_test 62.99% <ø> (ø)
Predictions_plugin_unit_test 35.94% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.48% <ø> (ø)
unit_tests 68.15% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants