Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for email mfa #94

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add support for email mfa #94

wants to merge 9 commits into from

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Sep 13, 2024

Description of changes:

Adding support for Email MFA:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harsh62 harsh62 requested review from a team as code owners September 13, 2024 16:04
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 41.93548% with 36 lines in your changes missing coverage. Please review.

Project coverage is 41.78%. Comparing base (1ec95fb) to head (b855272).

Files with missing lines Patch % Lines
.../States/ContinueSignInWithEmailMFASetupState.swift 0.00% 22 Missing ⚠️
...urces/Authenticator/Utilities/PreviewFactory.swift 0.00% 7 Missing ⚠️
Sources/Authenticator/Models/Internal/Step.swift 0.00% 4 Missing ⚠️
...tes/ContinueSignInWithMFASetupSelectionState.swift 91.30% 2 Missing ⚠️
.../Authenticator/States/AuthenticatorBaseState.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   41.81%   41.78%   -0.03%     
==========================================
  Files          41       43       +2     
  Lines        1906     1967      +61     
==========================================
+ Hits          797      822      +25     
- Misses       1109     1145      +36     
Flag Coverage Δ
Authenticator 41.78% <41.93%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants