feat(api): Add async protocol implementation for token request interceptors #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royjit
changed the title
royjit
changed the title
royjit
force-pushed
the
royjit.asynctokeninterceptor
branch
from
9d28cc2 to
97794e5
Compare
5d
approved these changes
Apr 19, 2023
| tokenResult: Result<String, Error>) -> AppSyncMessage { | ||
|
|
||
| guard let authToken = try? tokenResult.get() else { | ||
| log.warn("Missing authentication token for subscription") |
There was a problem hiding this comment.
nit: consider log the error if it's failure case.
royjit
added a commit
that referenced
this pull request
Apr 21, 2023
royjit
added a commit
that referenced
this pull request
Apr 21, 2023
9 tasks
royjit
added a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
AmplifyAuthTokenProviderAuthTokenProviderAppSyncRealTimeClient>= 3.1.0General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.