Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Async IAM signing #2871

Merged
merged 4 commits into from
Apr 20, 2023
Merged

feat(api): Async IAM signing #2871

merged 4 commits into from
Apr 20, 2023

Conversation

royjit
Copy link
Contributor

@royjit royjit commented Apr 18, 2023 •
edited
Loading

Issue #

Description

  • Add Async flavor for IAMAuthInterceptor protocol

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@royjit royjit marked this pull request as ready for review April 18, 2023 01:44
@royjit royjit requested a review from a team as a code owner April 18, 2023 01:44
@royjit royjit force-pushed the royjit.asynctokeninterceptor branch from 9d28cc2 to 97794e5 Compare April 18, 2023 20:35
@royjit royjit changed the title feat: Async IAM signing feat(api): Async IAM signing Apr 18, 2023
@royjit royjit force-pushed the royjit.asynciamsigning branch from 8fa833e to 7a8312c Compare April 18, 2023 21:44
Base automatically changed from royjit.asynctokeninterceptor to royjit.feat.asyncinterceptor April 19, 2023 19:45
@royjit royjit force-pushed the royjit.asynciamsigning branch from 7a8312c to fb8d97b Compare April 19, 2023 19:46
@royjit royjit merged commit 6e9b5f5 into royjit.feat.asyncinterceptor Apr 20, 2023
@royjit royjit deleted the royjit.asynciamsigning branch April 20, 2023 00:57
@royjit royjit mentioned this pull request Apr 20, 2023
Closed
royjit added a commit that referenced this pull request Apr 21, 2023
@royjit
feat(api): Add async protocol method for request interceptors IAM sig…
7ef1526 
…ning (#2871)
@royjit royjit mentioned this pull request Apr 26, 2023
Merged
9 tasks
royjit added a commit that referenced this pull request Apr 26, 2023
@royjit
feat(api): Add async protocol method for request interceptors IAM sig…
0041986 
…ning (#2871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5d 5d 5d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royjit @5d