Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add new storage gen2 APIs #3559

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

phantumcode
Copy link
Member

Issue #

Description

  • Add new APIs for Storage that takes in a StoragePath
  • stubbed out current implementation in AWSS3StoragePlugin to be implemented next
  • mark existing APIs that takes in key as deprecated

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner March 11, 2024 15:14
@phantumcode phantumcode merged commit 0d13d9f into feature/gen2_storage Mar 11, 2024
74 checks passed
@phantumcode phantumcode deleted the phantum/gen2_api_updates branch March 11, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants