Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(geo): add place index backend #3681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented May 7, 2024

Issue #

Description

Add place index for Geo backend stack. All integ tests are now passing

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner May 7, 2024 14:01
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (50e001f) to head (ac2434d).
Report is 78 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3681       +/-   ##
===========================================
- Coverage   79.01%   68.45%   -10.56%     
===========================================
  Files         288      926      +638     
  Lines       10128    31553    +21425     
===========================================
+ Hits         8003    21601    +13598     
- Misses       2125     9952     +7827     
Flag Coverage Δ
Amplify 48.19% <ø> (?)
Auth_plugin_unit_test 79.34% <ø> (+0.32%) ⬆️
DataStore_plugin_unit_test 82.44% <ø> (?)
Geo_plugin_unit_test 73.50% <ø> (?)
Logging_plugin_unit_test 62.87% <ø> (?)
Predictions_plugin_unit_test 37.31% <ø> (?)
Storage_plugin_unit_test 76.75% <ø> (?)
unit_tests 68.45% <ø> (-10.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant