Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Auth): Add logging to non throwing tasks #3791

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jul 23, 2024

Issue #

Description

Cleaning up logs

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

1 similar comment
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (b3fe944) to head (19343b6).

Files Patch % Lines
...s/Core/AWSPluginsCore/Keychain/KeychainStore.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3791      +/-   ##
==========================================
- Coverage   68.52%   68.50%   -0.02%     
==========================================
  Files        1080     1080              
  Lines       37616    37604      -12     
==========================================
- Hits        25775    25761      -14     
- Misses      11841    11843       +2     
Flag Coverage Δ
API_plugin_unit_test 68.83% <ø> (ø)
AWSPluginsCore 68.71% <0.00%> (+0.14%) ⬆️
Amplify 47.59% <ø> (+0.03%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.67% <100.00%> (-0.09%) ⬇️
DataStore_plugin_unit_test 81.20% <ø> (-0.02%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.50% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 marked this pull request as ready for review July 23, 2024 18:51
@harsh62 harsh62 requested a review from a team as a code owner July 23, 2024 18:51
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@github-actions github-actions bot requested a review from a team as a code owner July 24, 2024 20:09
@harsh62 harsh62 changed the title fix(Auth): Add logging to non throwing tasks chore(Auth): Add logging to non throwing tasks Jul 24, 2024
ruisebas
ruisebas previously approved these changes Aug 21, 2024
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@harsh62 harsh62 merged commit bdfa37a into main Aug 21, 2024
@harsh62 harsh62 deleted the task-log-improvement branch August 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants