-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Auth): Add logging to non throwing tasks #3791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Breakage Report✅ No Public API Breaking Change detected |
API Breakage Report✅ No Public API Breaking Change detected |
1 similar comment
API Breakage Report✅ No Public API Breaking Change detected |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3791 +/- ##
==========================================
- Coverage 68.52% 68.50% -0.02%
==========================================
Files 1080 1080
Lines 37616 37604 -12
==========================================
- Hits 25775 25761 -14
- Misses 11841 11843 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
API Breakage Report✅ No Public API Breaking Change detected |
harsh62
changed the title
fix(Auth): Add logging to non throwing tasks
chore(Auth): Add logging to non throwing tasks
Jul 24, 2024
harsh62
force-pushed
the
task-log-improvement
branch
from
August 21, 2024 14:55
a5867ce
to
3787467
Compare
ruisebas
previously approved these changes
Aug 21, 2024
API Breakage Report✅ No Public API Breaking Change detected |
ruisebas
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
Cleaning up logs
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.