Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storage): Implementing support for multiple buckets #3839

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Aug 27, 2024

Issues:

Description

This PR adds multiple bucket support to all Amplify Storage APIs.

All changes have been reviewed in the previous PRs:

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
    • Integration Tests | Storage
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 60.30151% with 79 lines in your changes missing coverage. Please review.

Project coverage is 68.33%. Comparing base (e373bde) to head (49ec259).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...orage/Operation/Request/StorageGetURLRequest.swift 0.00% 10 Missing ⚠️
...e/Operation/Request/StorageUploadDataRequest.swift 0.00% 9 Missing ⚠️
...e/Operation/Request/StorageUploadFileRequest.swift 0.00% 9 Missing ⚠️
...Operation/Request/StorageDownloadDataRequest.swift 0.00% 8 Missing ⚠️
...Operation/Request/StorageDownloadFileRequest.swift 0.00% 8 Missing ⚠️
...Storage/Operation/Request/StorageListRequest.swift 36.36% 7 Missing ⚠️
Amplify/Categories/Storage/StorageBucket.swift 0.00% 7 Missing ⚠️
...lugin/AWSS3StoragePlugin+AsyncClientBehavior.swift 50.00% 7 Missing ⚠️
...orage/Operation/Request/StorageRemoveRequest.swift 0.00% 6 Missing ⚠️
...mplify/Core/Configuration/AmplifyOutputsData.swift 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
- Coverage   68.39%   68.33%   -0.07%     
==========================================
  Files        1082     1084       +2     
  Lines       37699    37858     +159     
==========================================
+ Hits        25784    25869      +85     
- Misses      11915    11989      +74     
Flag Coverage Δ
API_plugin_unit_test 69.32% <ø> (ø)
AWSPluginsCore 68.53% <ø> (ø)
Amplify 47.10% <5.55%> (-0.46%) ⬇️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.27% <ø> (-0.04%) ⬇️
DataStore_plugin_unit_test 81.30% <ø> (+0.01%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 36.86% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 77.25% <91.33%> (+0.44%) ⬆️
unit_tests 68.33% <60.30%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruisebas ruisebas marked this pull request as ready for review September 13, 2024 15:30
@ruisebas ruisebas requested review from a team as code owners September 13, 2024 15:30
phantumcode
phantumcode previously approved these changes Sep 13, 2024
@ruisebas ruisebas merged commit c229b65 into main Sep 17, 2024
82 checks passed
@ruisebas ruisebas deleted the feature/multibucket-storage branch September 17, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants