Skip to content

Conversation

thisisabhash
Copy link
Member

Issue #

Canary github action workflow is failing.
https://github.com/aws-amplify/amplify-swift/actions/workflows/canary.yml

Description

Update timeout for fastlane xcodebuild command

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner August 28, 2025 20:47
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.94%. Comparing base (ac7eeae) to head (03fe123).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4047      +/-   ##
==========================================
+ Coverage   67.80%   73.94%   +6.13%     
==========================================
  Files        1129      334     -795     
  Lines       52482    16232   -36250     
==========================================
- Hits        35584    12002   -23582     
+ Misses      16898     4230   -12668     
Flag Coverage Δ
API_plugin_unit_test ?
AWSPluginsCore ?
Amplify ?
Analytics_plugin_unit_test ?
Auth_plugin_unit_test 73.62% <ø> (-0.02%) ⬇️
DataStore_plugin_unit_test ?
Geo_plugin_unit_test ?
Logging_plugin_unit_test ?
Predictions_plugin_unit_test ?
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test ?
unit_tests 73.94% <ø> (+6.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thisisabhash
Copy link
Member Author

@harsh62 harsh62 merged commit 1e24d45 into main Aug 29, 2025
100 of 104 checks passed
@harsh62 harsh62 deleted the chore/fix-canary-ci-cd branch August 29, 2025 16:47
ekjotmultani pushed a commit that referenced this pull request Sep 3, 2025
…n canary build (#4047)

* chore(build): increase fastlane timeout for failing canary

* update code

* update code

* update canaries project

* update amplify dependency

* revert gems to older version for dependency review failure

* revert gem with incompatible license

* update code

* update code

* update code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants