Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service exception handling #21

Merged
merged 5 commits into from
Jun 2, 2023
Merged

fix: service exception handling #21

merged 5 commits into from
Jun 2, 2023

Conversation

atierian
Copy link
Member

@atierian atierian commented May 5, 2023

Issue #, if available:

Description of changes:
Updates to Amplify Swift >= v2.11.0 to allow for better service error propagation.

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian marked this pull request as ready for review May 23, 2023 17:59
@atierian atierian requested review from a team as code owners May 23, 2023 17:59
@atierian atierian merged commit 6c96cdd into main Jun 2, 2023
@atierian atierian deleted the fix/error-handling branch June 2, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants