fix: data race causing multiple initial events and crash with low net… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantumcode
approved these changes
Jul 13, 2023
phantumcode
pushed a commit
that referenced
this pull request
Jul 13, 2023
#40) * fix: data race causing multiple initial events and crash with low network throughput * invoke oncomplete
phantumcode
added a commit
that referenced
this pull request
Jul 20, 2023
* main: chore: update user agent string with correct library version (#42) fix: update no match timeout check from frame count to elapsed time (#41) fix: send client close frame (#39) fix: data race causing multiple initial events and crash with low net… (#40) chore: remove countdown from liveness session check (#36)
devedup
pushed a commit
to devedup/amplify-ui-swift-liveness
that referenced
this pull request
Sep 12, 2023
aws-amplify#40) * fix: data race causing multiple initial events and crash with low network throughput * invoke oncomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds some checks to prevent:
AVAssetWriterfrom being started multiple times (crash).Work is being done on a separate branch
experimental/dqectomyto remove the situations that require these checks. Considering that's a larger change and the urgency of the existing issues, that will go out in a future release.Check points: (check or cross out if not relevant)
Added new tests to cover change, if neededDocumentation update for the change if requiredIf breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.