Updated to QR code page #1083
Updated to QR code page #1083
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
🦋 Changeset detectedLatest commit: bed81c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request introduces 1 alert when merging bed81c1 into a4a1e21 - view on LGTM.com new alerts:
|
| let secretKey = ref(''); | ||
| let copyTextLabel = ref(translate('COPY')); | ||
|
|
||
| function copyText() { | ||
| navigator.clipboard.writeText(secretKey.value); | ||
| copyTextLabel.value = translate('COPIED'); | ||
| } |
There was a problem hiding this comment.
This was the only change, just moved script setup to top.
| @media (max-width: 30rem) { | ||
| word-break: break-all; | ||
| } |
There was a problem hiding this comment.
What do you think about making [data-amplify-copy] hidden if not on mobile?
There was a problem hiding this comment.
I dunno, I was just using a QR code the other day, and I appreciated how the secret key was also displayed. I don't think it has to be just for mobile.
There was a problem hiding this comment.
That's fair! My only concern is that end-users won't know what to do with that secret key, but customers can use header slots to add directions.
There was a problem hiding this comment.
Yeah, I was debating back and forth if I should add in some instructions on how to add 2FA to Authy, or Google Authenticator, but I didn't want to add more requirements unless a customer wanted too.
And they can add in their own with a slot, so you're right.
Issue #, if available:
#881
Description of changes:
Updated QR code page so users can copy the secret key, instead of using QR code.
setuptotp.mp4
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.