Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update controlled input to reflect changes in controlled value #1292

Merged
merged 7 commits into from
Feb 14, 2022

Conversation

jacoblogan
Copy link
Contributor

*Issue #1283, #1284

*Description of changes:Update StepperField and CheckboxField primitives to update the visual portion of the component when a controlled value is updated.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

checkboxField

stepper

…nts update visual input when controlled values are updated
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2022

🦋 Changeset detected

Latest commit: 7f1b005

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacoblogan jacoblogan temporarily deployed to ci February 10, 2022 09:39 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 10, 2022 09:39 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 10, 2022 09:39 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 10, 2022 09:39 Inactive
Copy link
Contributor

@Milan-Shah Milan-Shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 19:12 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 19:12 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 19:12 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 19:12 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 21:36 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 21:36 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 21:36 Inactive
@jacoblogan jacoblogan temporarily deployed to ci February 11, 2022 21:36 Inactive
@jacoblogan jacoblogan merged commit aa051a0 into main Feb 14, 2022
@jacoblogan jacoblogan deleted the field-update branch February 14, 2022 16:55
@github-actions github-actions bot mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants