Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fix): remove Theme tab from demos #1723

Merged
merged 3 commits into from
Apr 19, 2022
Merged

docs(fix): remove Theme tab from demos #1723

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6500030
temporarily remove Theme tab from docs demos
Apr 19, 2022
fad5622
removed nullish coalescing operator
joebuono Apr 19, 2022
4e84c08
small typo
joebuono Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/src/components/Demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export const Demo = ({
<TabItem title="Props">
<View padding={`${tokens.space.medium} 0`}>{propControls}</View>
</TabItem>
{themeControls ?? <TabItem title="Theme">{themeControls}</TabItem>}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to {themeControls ? <TabItem title="Theme">{themeControls}</TabItem> : null} ?

{/* Temporarily removing the Theme tab until we figure out a way
to let customers dynamically edit a theme object in the demos
*/}
{/* {themeControls ? <TabItem title="Theme">{themeControls}</TabItem> : null} */}
</Tabs>
</Flex>
<View
Expand Down