Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing translation for force new password page #1859

Merged
merged 4 commits into from
May 9, 2022

Conversation

ErikCH
Copy link
Contributor

@ErikCH ErikCH commented May 9, 2022

Description of changes

Added missing translation for force new password page for React

Issue #, if available

#1789

Description of how you validated changes

Added cypress test

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022

🦋 Changeset detected

Latest commit: f9962cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

</Text>
)}

<RemoteErrorMessage />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using RemoteErrorMessage so it looks and behaves like our other error messages in other components.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean!

@ErikCH ErikCH temporarily deployed to ci May 9, 2022 21:13 Inactive
@ErikCH ErikCH temporarily deployed to ci May 9, 2022 21:13 Inactive
@ErikCH ErikCH temporarily deployed to ci May 9, 2022 21:13 Inactive
@ErikCH ErikCH temporarily deployed to ci May 9, 2022 21:13 Inactive
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛥️

Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@ErikCH ErikCH merged commit a130303 into main May 9, 2022
@ErikCH ErikCH deleted the fix-missing-translations branch May 9, 2022 23:22
@github-actions github-actions bot mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants