Button disabled #1876
Merged
Button disabled #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f1e959c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zchenwei
reviewed
May 11, 2022
| @@ -25,6 +25,20 @@ describe('Button test suite', () => { | |||
| expect(link.classList).toContain('amplify-button--link'); | |||
| }); | |||
|
|
|||
| it('should add the disabled class with the disabled attribute', async () => { | |||
| render( | |||
| <div> | |||
There was a problem hiding this comment.
nit: <div> seems redundant for a single button
zchenwei
reviewed
May 11, 2022
|
|
||
| const disabled = await screen.findByTestId('disabled'); | ||
|
|
||
| expect(disabled.classList).toContain('amplify-button--disabled'); |
There was a problem hiding this comment.
Suggested change
| expect(disabled.classList).toContain('amplify-button--disabled'); | |
| expect(disabled).toHaveClass('amplify-button--disabled'); |
zchenwei
approved these changes
May 11, 2022
reesscot
approved these changes
May 11, 2022
reesscot
reviewed
May 11, 2022
| @@ -25,6 +25,18 @@ describe('Button test suite', () => { | |||
| expect(link.classList).toContain('amplify-button--link'); | |||
| }); | |||
|
|
|||
| it('should add the disabled class with the disabled attribute', async () => { | |||
There was a problem hiding this comment.
Should we add a test that FieldGroupIconButton works correctly now?
reesscot
approved these changes
May 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is to add the disabled class to Button primitives when the disabled attribute is present
Description of how you validated changes
Validated on docs site with the pagination primitive which uses an
as={Button}that strips out theisDisabledpropertyChecklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.