fix(geo): Point to react-map-gl es5 bundle #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f31f3d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wlee221
approved these changes
May 12, 2022
joebuono
approved these changes
May 12, 2022
zchenwei
approved these changes
May 12, 2022
thaddmt
approved these changes
May 12, 2022
|
@zchenwei Yeah I agree, it's not standard for publishing an es5 bundle which caused us to miss potential problems with es2020 features. I think I'll open a discussion regarding your point in the library's repository, but it's beyond the scope of this specific PR for now. |
Merged
2 tasks
slaymance
added a commit
that referenced
this pull request
May 17, 2022
This reverts commit fb605b8.
slaymance
added a commit
that referenced
this pull request
May 17, 2022
wlee221
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some users have reported issues with ES 2020 features that are used by our
react-map-gldependency and certain build tools that they're using (e.g. Create React App v4). This PR updates our use ofreact-map-glto point to the ES5-compatible bundle provided by the library which will mitigate issues related to ES 2020 features.Issue #, if available
#1656
Description of how you validated changes
Manually validated this change by sym-linking it to a CRA4 sample application using the
<MapView>component and verified that there were no build issues and the workaround suggested in #1656 is not needed.Checklist
yarn testpassessideEffectsfield updated - N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.