-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui-react-core): replace tsup with tsc in ui-react-core #2008
chore(ui-react-core): replace tsup with tsc in ui-react-core #2008
Conversation
|
}, | ||
"include": ["src/**/*.ts", "src/**/*.tsx"], | ||
"exclude": ["node_modules", "src/**/*.test.ts", "src/**/*.test.tsx"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore(react-core): add ui-react-core and configuration * chore(ui-react-core): add ui-react-core to bump-react.md (#1839) * chore(react-core): update linting rules to reflect rules in ui-react package (#1907) * chore(react-core): delete example code (#1912) * chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911) * fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954) * chore(ui-react-core): add react devDeps (#2007) * chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008) * chore(rwa): build react-core during CI (#2627) * chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605) Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
* chore(react-core): add ui-react-core and configuration * chore(ui-react-core): add ui-react-core to bump-react.md (#1839) * chore(react-core): update linting rules to reflect rules in ui-react package (#1907) * chore(react-core): delete example code (#1912) * chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911) * fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954) * chore(ui-react-core): add react devDeps (#2007) * chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008) * chore(rwa): build react-core during CI (#2627) * chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605) Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
* chore(react-core): add ui-react-core and configuration * chore(ui-react-core): add ui-react-core to bump-react.md (#1839) * chore(react-core): update linting rules to reflect rules in ui-react package (#1907) * chore(react-core): delete example code (#1912) * chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911) * fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954) * chore(ui-react-core): add react devDeps (#2007) * chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008) * chore(rwa): build react-core during CI (#2627) * chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605) Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
* feat(ui-react-core): merge ui-react-core in to main (#2659) * chore(react-core): add ui-react-core and configuration * chore(ui-react-core): add ui-react-core to bump-react.md (#1839) * chore(react-core): update linting rules to reflect rules in ui-react package (#1907) * chore(react-core): delete example code (#1912) * chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911) * fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954) * chore(ui-react-core): add react devDeps (#2007) * chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008) * chore(rwa): build react-core during CI (#2627) * chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605) Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> * chore(workflow): Bump setup-node version in our workflows (#2654) * chore(rna): add test-rna-prs.yml (#2664) * chore(ui-react-core): add .lintstagedrc.js (#2677) * Updates to dev center nav (#2658) Co-authored-by: Jacob Logan <lognjc@amazon.com> Co-authored-by: Danny Banks <djb@amazon.com> Co-authored-by: jacoblogan <jacob.maiola.logan@gmail.com> Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com> * chore(ui-react): remove deprecated useAuthenticator internals (#2676) * chore(ui-react): remove deprecated useAuthenticator internals Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com> Co-authored-by: Ioana Brooks <68251134+ioanabrooks@users.noreply.github.com> Co-authored-by: Tim Nguyen <54393192+timngyn@users.noreply.github.com> Co-authored-by: Jacob Logan <lognjc@amazon.com> Co-authored-by: Danny Banks <djb@amazon.com> Co-authored-by: jacoblogan <jacob.maiola.logan@gmail.com> Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>
Description of changes
Replace
tsup
with vanillatsc
build commands in @aws-amplify/ui-react-coreIssue #, if available
NA
Description of how you validated changes
Manual tested with example app
Checklist
yarn test
passessideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.