Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-react-core): replace tsup with tsc in ui-react-core #2008

Merged

Conversation

calebpollman
Copy link
Member

Description of changes

Replace tsup with vanilla tsc build commands in @aws-amplify/ui-react-core

Issue #, if available

NA

Description of how you validated changes

Manual tested with example app

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2022

⚠️ No Changeset found

Latest commit: b25adb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@calebpollman calebpollman marked this pull request as ready for review May 31, 2022 19:05
},
"include": ["src/**/*.ts", "src/**/*.tsx"],
"exclude": ["node_modules", "src/**/*.test.ts", "src/**/*.test.tsx"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebpollman calebpollman merged commit 0103540 into aws-amplify:react-core/main May 31, 2022
@calebpollman calebpollman deleted the react-core/use-tsc branch May 31, 2022 19:15
calebpollman added a commit to calebpollman/amplify-ui that referenced this pull request Aug 28, 2022
calebpollman added a commit that referenced this pull request Sep 29, 2022
* chore(react-core): add ui-react-core and configuration

* chore(ui-react-core): add ui-react-core to bump-react.md (#1839)

* chore(react-core): update linting rules to reflect rules in ui-react package (#1907)

* chore(react-core): delete example code (#1912)

* chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911)

* fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954)

* chore(ui-react-core): add react devDeps (#2007)

* chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008)

* chore(rwa): build react-core during CI (#2627)

* chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605)

Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
calebpollman added a commit that referenced this pull request Sep 30, 2022
* chore(react-core): add ui-react-core and configuration

* chore(ui-react-core): add ui-react-core to bump-react.md (#1839)

* chore(react-core): update linting rules to reflect rules in ui-react package (#1907)

* chore(react-core): delete example code (#1912)

* chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911)

* fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954)

* chore(ui-react-core): add react devDeps (#2007)

* chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008)

* chore(rwa): build react-core during CI (#2627)

* chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605)

Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>

Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
ioanabrooks pushed a commit that referenced this pull request Oct 1, 2022
* chore(react-core): add ui-react-core and configuration

* chore(ui-react-core): add ui-react-core to bump-react.md (#1839)

* chore(react-core): update linting rules to reflect rules in ui-react package (#1907)

* chore(react-core): delete example code (#1912)

* chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911)

* fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954)

* chore(ui-react-core): add react devDeps (#2007)

* chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008)

* chore(rwa): build react-core during CI (#2627)

* chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605)

Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
calebpollman added a commit that referenced this pull request Oct 4, 2022
* feat(ui-react-core): merge ui-react-core in to main (#2659)

* chore(react-core): add ui-react-core and configuration

* chore(ui-react-core): add ui-react-core to bump-react.md (#1839)

* chore(react-core): update linting rules to reflect rules in ui-react package (#1907)

* chore(react-core): delete example code (#1912)

* chore(react-core): set tsconfig.json jsx field to react, add tsconfig.dev.json for test file ts support (#1911)

* fix(ui-react-core): update prebuild and clean commands, remove react as a devDep (#1954)

* chore(ui-react-core): add react devDeps (#2007)

* chore(ui-react-core): replace tsup with tsc in ui-react-core (#2008)

* chore(rwa): build react-core during CI (#2627)

* chore(ui-react-core): migrate useAuthenticator and AuthenticatorProvider (#2605)

Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>

* chore(workflow): Bump setup-node version in our workflows (#2654)

* chore(rna): add test-rna-prs.yml (#2664)

* chore(ui-react-core): add .lintstagedrc.js (#2677)

* Updates to dev center nav (#2658)

Co-authored-by: Jacob Logan <lognjc@amazon.com>
Co-authored-by: Danny Banks <djb@amazon.com>
Co-authored-by: jacoblogan <jacob.maiola.logan@gmail.com>
Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>

* chore(ui-react): remove deprecated useAuthenticator internals (#2676)

* chore(ui-react): remove deprecated useAuthenticator internals

Co-authored-by: William Lee <43682783+wlee221@users.noreply.github.com>
Co-authored-by: Ioana Brooks <68251134+ioanabrooks@users.noreply.github.com>
Co-authored-by: Tim Nguyen <54393192+timngyn@users.noreply.github.com>
Co-authored-by: Jacob Logan <lognjc@amazon.com>
Co-authored-by: Danny Banks <djb@amazon.com>
Co-authored-by: jacoblogan <jacob.maiola.logan@gmail.com>
Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants