Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): adding theme key support on more style props #2077

Merged
merged 6 commits into from
Jun 13, 2022

Conversation

zchenwei
Copy link
Contributor

@zchenwei zchenwei commented Jun 11, 2022

Description of changes

Add theme key support for font-family, line-height, opacity, box-shadow and transform.

Issue #, if available

A follow-up on #2054

Description of how you validated changes

Tested and validated locally

Checklist

  • PR description included
  • yarn test passes
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2022

🦋 Changeset detected

Latest commit: 593716d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui-react Minor
@aws-amplify/ui Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zchenwei zchenwei temporarily deployed to ci June 11, 2022 21:58 Inactive
@zchenwei zchenwei temporarily deployed to ci June 11, 2022 21:58 Inactive
@zchenwei zchenwei temporarily deployed to ci June 11, 2022 21:58 Inactive
@zchenwei zchenwei temporarily deployed to ci June 11, 2022 21:58 Inactive
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zchenwei zchenwei temporarily deployed to ci June 13, 2022 17:59 Inactive
@zchenwei zchenwei temporarily deployed to ci June 13, 2022 17:59 Inactive
@zchenwei zchenwei temporarily deployed to ci June 13, 2022 17:59 Inactive
@zchenwei zchenwei temporarily deployed to ci June 13, 2022 17:59 Inactive
@zchenwei zchenwei merged commit 736cfe7 into main Jun 13, 2022
@zchenwei zchenwei deleted the chenwz-theme-key-rest branch June 13, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants