-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone tokens #2113
Phone tokens #2113
Conversation
🦋 Changeset detectedLatest commit: 981d2c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
docs/src/pages/[platform]/components/selectfield/examples/SelectFieldThemeExample.tsx
Show resolved
Hide resolved
docs/src/pages/[platform]/components/phonenumberfield/examples/ThemingExample.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! May want to double check the contrast ratio?
docs/src/pages/[platform]/components/phonenumberfield/examples/ThemingExample.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/[platform]/components/phonenumberfield/examples/ThemingExample.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes
add design tokens to phone number field and add matching tokens to selectfield and textfield
Checklist
yarn test
passessideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.