Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add design tokens to radio group #2114

Merged
merged 9 commits into from
Jun 22, 2022
Merged

add design tokens to radio group #2114

merged 9 commits into from
Jun 22, 2022

Conversation

jacoblogan
Copy link
Contributor

Description of changes

Add Design Tokens to radiogroup primitive

Screen Shot 2022-06-15 at 3 59 55 AM

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2022

🦋 Changeset detected

Latest commit: 7ef49e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui Minor
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacoblogan jacoblogan temporarily deployed to ci June 15, 2022 11:14 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 15, 2022 11:14 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 15, 2022 11:14 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 15, 2022 11:14 Inactive
zchenwei
zchenwei previously approved these changes Jun 17, 2022
Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Plz make sure the color are contrasty enough in both light/dark mode

@jacoblogan jacoblogan temporarily deployed to ci June 17, 2022 11:10 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 17, 2022 11:10 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 17, 2022 11:10 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 17, 2022 11:10 Inactive
hbuchel
hbuchel previously approved these changes Jun 17, 2022
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joebuono
joebuono previously approved these changes Jun 18, 2022
@jacoblogan jacoblogan temporarily deployed to ci June 18, 2022 18:04 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 18, 2022 18:04 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 18, 2022 18:04 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 18, 2022 18:04 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 20, 2022 21:44 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 20, 2022 21:44 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 20, 2022 21:44 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 20, 2022 21:44 Inactive
Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@joebuono joebuono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacoblogan jacoblogan merged commit 710a6ec into main Jun 22, 2022
@jacoblogan jacoblogan deleted the radiogroup-tokens branch June 22, 2022 14:34
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants