Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fix): Fixed typo in ComponentClassObject #2180

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

joebuono
Copy link
Contributor

Description of changes

While updating the RadioGroupField docs, I was wondering why the Target Classes did not include amplify-radio__button. It turns out it was because of a typo in the ComponentClassObject.

Current:
Screen Shot 2022-06-22 at 6 14 53 PM

Updated:
Screen Shot 2022-06-22 at 6 17 52 PM

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joebuono joebuono requested a review from a team as a code owner June 22, 2022 22:19
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: 92eb9ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joebuono joebuono temporarily deployed to ci June 22, 2022 22:33 Inactive
@joebuono joebuono temporarily deployed to ci June 22, 2022 22:33 Inactive
@joebuono joebuono temporarily deployed to ci June 22, 2022 22:33 Inactive
@joebuono joebuono temporarily deployed to ci June 22, 2022 22:33 Inactive
@joebuono joebuono merged commit bb5aecd into main Jun 23, 2022
@joebuono joebuono deleted the bugfix-radiobutton-classname branch June 23, 2022 15:58
@github-actions github-actions bot mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants