fix(react): hub listener fix #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b8a77f.
🦋 Changeset detectedLatest commit: 0550a95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wlee221
commented
Jun 27, 2022
Comment on lines
8
to
11
| jest.mock('@aws-amplify/ui', () => ({ | ||
| ...(jest.requireActual('@aws-amplify/ui') as {}), | ||
| defaultAuthHubHandler: jest.fn(), | ||
| })); |
There was a problem hiding this comment.
Without this,
const hubHandlerSpy = jest.spyOn(UI, 'defaultAuthHubHandler');fails with
TypeError: Cannot redefine property: defaultAuthHubHandler
wlee221
commented
Jun 27, 2022
| event: 'tokenRefresh', | ||
| }); | ||
|
|
||
| expect(hubHandlerSpy).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
This has been failing due to
Expected number of calls: 1
Received number of calls: 0
but I could verify the function does get called. Looks like jest is not correctly mocking it?
wlee221
commented
Jun 27, 2022
packages/react/src/components/Authenticator/hooks/useAuthenticator/__tests__/Provider.test.tsx
Show resolved
Hide resolved
wlee221
commented
Jun 30, 2022
| (data) => { | ||
| handler(data, service); | ||
| }, | ||
| 'authenticator-hub-handler' |
There was a problem hiding this comment.
This is the hub handler name; added mostly for debugging purposes.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR ensures that Authenticator correctly attaches and reattaches hub listener on React 18 StrictMode.
Problem
In React 18 StrictMode, React will always simulate unmounting and remounting whenever components initializes. This persist states and refs between the remounts:
This broke the hub listener pattern we used in React, because we've been expecting
refvalue to be reset between remounts.Fix
This PR fixes by this by not using
useRefat all. Even if component were to remount, it'll reattach immediately.Issue #, if available
Description of how you validated changes
Verified manually on
@experimentaltag. Added some unit test as well.Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.