ci: add react-native and react-core to test matrix #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
wlee221
commented
Jul 28, 2022
| @@ -245,6 +251,10 @@ jobs: | |||
| if: steps.restore-ui-cache.outputs.cache-hit != 'true' | |||
| run: yarn ui build | |||
|
|
|||
| - name: Build react-core package | |||
| if: ${{ matrix.package == 'react' }} | |||
There was a problem hiding this comment.
We don't have react-native e2e test yet, so we only check for === 'react'
…-native+react-core
…-native+react-core
calebpollman
approved these changes
Jul 29, 2022
…-native+react-core
…-native+react-core
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds add react-native and react-core to test matrix.
Issue #, if available
Description of how you validated changes
Creating a POC PR
Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.