Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-react): Hide decorative alert icons from screen readers #2368

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

ioanabrooks
Copy link
Contributor

@ioanabrooks ioanabrooks commented Jul 28, 2022

Description of changes

This change hides decorative alert icons such that redundant text is not announced by screen readers.

Issue #, if available

N/A

Description of how you validated changes

Deployed docs locally and added unit test.

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ioanabrooks ioanabrooks requested a review from a team as a code owner July 28, 2022 23:26
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

🦋 Changeset detected

Latest commit: f68ff73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ioanabrooks ioanabrooks requested a review from hbuchel July 28, 2022 23:27
@ioanabrooks ioanabrooks temporarily deployed to ci July 28, 2022 23:38 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci July 28, 2022 23:38 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci July 28, 2022 23:38 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci July 28, 2022 23:38 Inactive
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one question about IconCheckCircle

packages/react/src/primitives/Alert/AlertIcon.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ioanabrooks ioanabrooks temporarily deployed to ci July 29, 2022 16:29 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci July 29, 2022 16:29 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci July 29, 2022 16:29 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci July 29, 2022 16:29 Inactive
@ioanabrooks ioanabrooks merged commit 64fa669 into main Jul 29, 2022
@ioanabrooks ioanabrooks deleted the react/alert-icons-accessibility branch July 29, 2022 18:59
This was referenced Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants