-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui-react-native): Add storybook #2464
chore(ui-react-native): Add storybook #2464
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Left a blocking comment on the ui-react-native
exports and some general feedback/questions/nits
@@ -4,12 +4,12 @@ This directory contains example apps for each framework we support. | |||
|
|||
## Examples Development | |||
|
|||
1. Create or Update an example at [`examples/{next,vue,angular}/...`](examples) | |||
1. Create or Update an example at [`examples/{next,react-native,vue,angular}/...`](examples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
|
||
For your `aws-exports.js`, you can [reference an existing or create a new environment](../environments/README.md). | ||
|
||
1. Run your example at monorep root: `yarn {react,vue,angular}-example dev` | ||
1. Run your example at monorep root: `yarn {react,react-native,vue,angular}-example dev` | ||
1. Visit your example (e.g. <http://localhost:3000/ui/components/authenticator/sign-up-with-username>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should update this line as well since it is specific to browser frameworks
Co-authored-by: Caleb Pollman <cpollman@amazon.com>
Co-authored-by: Caleb Pollman <cpollman@amazon.com>
Co-authored-by: Caleb Pollman <cpollman@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Description of changes
Add Storybook support to RN example app for rapid prototyping. This change adds Storybook server as an optional way to run Storybook for the added benefit of being able to control multiple simulators/emulators with one click.
Issue #, if available
n/A
Description of how you validated changes
Tested in ios simulator and android emulator.
With Storybook server:
Without storybook server:
Checklist
yarn test
passessideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.