Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(in-app-messaging): resolve issues blocking CI #2467

Conversation

calebpollman
Copy link
Member

Description of changes

  • add react-native-safe-area-context mock, remove individual mocks
  • add yarn react-core test and yarn react-native test to yarn test
  • update the exports snapshot in @aws-amplify/ui-react

Issue #, if available

NA

Description of how you validated changes

yarn test

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested a review from a team as a code owner August 16, 2022 00:03
@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

⚠️ No Changeset found

Latest commit: cab85c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wlee221 wlee221 added the run-tests Adding this label will trigger tests to run label Aug 16, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 16, 2022
@wlee221 wlee221 temporarily deployed to ci August 16, 2022 00:22 Inactive
@wlee221 wlee221 temporarily deployed to ci August 16, 2022 00:22 Inactive
@wlee221 wlee221 temporarily deployed to ci August 16, 2022 00:22 Inactive
@wlee221 wlee221 temporarily deployed to ci August 16, 2022 00:22 Inactive
Copy link
Contributor

@ioanabrooks ioanabrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for unblocking this!

@ioanabrooks ioanabrooks merged commit 9799ec5 into aws-amplify:in-app-messaging/main Aug 16, 2022
@calebpollman calebpollman deleted the in-app-messaging/mock-react-native-safe-area-context branch August 16, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants