chore(rwa): update user lookup in getServiceFacade, authenticator util typing and useAuthenticator updates #2538

calebpollman · 2022-08-30T17:16:58Z

Description of changes

add return types to Authenticator state machine utils in facade.ts
update user lookup in getServiceContextFacade to initially check actorContext prior to falling back on state.context to allow removal of direct lookup of user from actorContext in the SetupTOTP UI components
minor changes to useAuthenticator to clean up duplication

Issue #, if available

NA

Description of how you validated changes

e2e tests

Checklist

PR description included
yarn test passes
Tests are updated
No side effects or sideEffects field updated
Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot · 2022-08-30T17:17:01Z

🦋 Changeset detected

Latest commit: 41ec1ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@aws-amplify/ui-react	Patch
@aws-amplify/ui	Patch
@aws-amplify/ui-vue	Patch
@aws-amplify/ui-angular	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lgtm-com · 2022-08-30T19:13:10Z

This pull request introduces 2 alerts when merging 8aa0b09 into c12e9f5 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2022-08-30T19:23:21Z

This pull request introduces 2 alerts when merging 331c42f into c12e9f5 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

ErikCH · 2022-08-31T22:24:38Z

packages/ui/src/helpers/authenticator/facade.ts

+
+  // check for user in actorContext prior to state context. actorContext is more "up to date",
+  // but is not available on all states
+  const user = actorContext?.user ?? state.context?.user;


wlee221

LGTM

ErikCH

This looks like a good start. From looking at the Angular and Vue implementations, I noticed that we have some discrepancies in a few place, that can be looked at in future PRs. Angular still uses getServiceContextFacade in the authenticator.service while React and Vue are using composable/hooks with getServiceFacade. 👍

calebpollman · 2022-08-31T23:02:26Z

This looks like a good start. From looking at the Angular and Vue implementations, I noticed that we have some discrepancies in a few place, that can be looked at in future PRs. Angular still uses getServiceContextFacade in the authenticator.service while React and Vue are using composable/hooks with getServiceFacade. 👍

Good call out. Will make sure that they get addressed 👍

chore(rwa): improve machine typing

c824add

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 30, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 30, 2022

calebpollman temporarily deployed to ci August 30, 2022 17:27 Inactive

chore(rwa): add more Authenticator util types

8aa0b09

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 30, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 30, 2022

chore(rwa): update getFacade in useAuthenticator

331c42f

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 30, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 30, 2022

calebpollman temporarily deployed to ci August 30, 2022 19:29 Inactive

calebpollman changed the title ~~[POC - DO NOT MERGE] chore(rwa): improve machine typing~~ [POC - DO NOT MERGE] chore(rwa): authenticator util typing and useAuthenticator updates Aug 30, 2022

calebpollman added 2 commits August 30, 2022 16:26

chore(rwa): move facade types directly in to file

5d2d3ad

chore(rwa): extract user from actorContext instead of context

c38a013

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 30, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 30, 2022

calebpollman added 2 commits August 30, 2022 16:44

chore(rwa): remove extraneous export statements

0b94695

chore(rwa): add truthy check when evulating hasValidationErrors

d514f04

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 31, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 31, 2022

calebpollman had a problem deploying to ci August 31, 2022 00:16 Failure

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 31, 2022

calebpollman temporarily deployed to ci August 31, 2022 02:48 Inactive

chore(rwa): remove user destructure in getServiceContextFacade

f665515

calebpollman force-pushed the rwa/poc branch from f0d762d to f665515 Compare August 31, 2022 04:46

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 31, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 31, 2022

calebpollman temporarily deployed to ci August 31, 2022 04:56 Inactive

calebpollman changed the title ~~[POC - DO NOT MERGE] chore(rwa): authenticator util typing and useAuthenticator updates~~ chore(rwa): update user lookup in getServiceFacade, authenticator util typing and useAuthenticator updates Aug 31, 2022

calebpollman marked this pull request as ready for review August 31, 2022 21:32

calebpollman requested a review from a team as a code owner August 31, 2022 21:32

Create polite-singers-wait.md

41ec1ff

calebpollman added the run-tests Adding this label will trigger tests to run label Aug 31, 2022

github-actions bot removed the run-tests Adding this label will trigger tests to run label Aug 31, 2022

calebpollman temporarily deployed to ci August 31, 2022 22:22 Inactive

ErikCH reviewed Aug 31, 2022

View reviewed changes

wlee221 approved these changes Aug 31, 2022

View reviewed changes

ErikCH approved these changes Aug 31, 2022

View reviewed changes

calebpollman merged commit 4a4b5c9 into aws-amplify:main Aug 31, 2022

calebpollman deleted the rwa/poc branch August 31, 2022 23:01

github-actions bot mentioned this pull request Aug 31, 2022

Version Packages #2543

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(rwa): update user lookup in getServiceFacade, authenticator util typing and useAuthenticator updates #2538

chore(rwa): update user lookup in getServiceFacade, authenticator util typing and useAuthenticator updates #2538

calebpollman commented Aug 30, 2022 •

edited

Loading

changeset-bot bot commented Aug 30, 2022 •

edited

Loading

lgtm-com bot commented Aug 30, 2022

lgtm-com bot commented Aug 30, 2022

ErikCH Aug 31, 2022

wlee221 left a comment

ErikCH left a comment

calebpollman commented Aug 31, 2022

chore(rwa): update user lookup in getServiceFacade, authenticator util typing and useAuthenticator updates #2538

chore(rwa): update user lookup in getServiceFacade, authenticator util typing and useAuthenticator updates #2538

Conversation

calebpollman commented Aug 30, 2022 • edited Loading

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

changeset-bot bot commented Aug 30, 2022 • edited Loading

🦋 Changeset detected

lgtm-com bot commented Aug 30, 2022

lgtm-com bot commented Aug 30, 2022

ErikCH Aug 31, 2022

Choose a reason for hiding this comment

wlee221 left a comment

Choose a reason for hiding this comment

ErikCH left a comment

Choose a reason for hiding this comment

calebpollman commented Aug 31, 2022

calebpollman commented Aug 30, 2022 •

edited

Loading

changeset-bot bot commented Aug 30, 2022 •

edited

Loading