Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log failure metric #2646

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Fix log failure metric #2646

merged 2 commits into from
Sep 26, 2022

Conversation

0618
Copy link
Contributor

@0618 0618 commented Sep 26, 2022

Description of changes

  1. log-metric action would be skipped if the needed previous action is a failure

image

It's because the default is success() ref: Github's Docs

  1. the rename in chore(workflow): rename RuntimeTestsFailure to BuildAndRuntimeTestFailure #2638 forgot to change the workflow's name, so change it in this PR as well.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 requested a review from a team as a code owner September 26, 2022 21:19
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

⚠️ No Changeset found

Latest commit: cec1476

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0618 0618 temporarily deployed to ci September 26, 2022 21:33 Inactive
@0618 0618 temporarily deployed to ci September 26, 2022 21:33 Inactive
@0618 0618 temporarily deployed to ci September 26, 2022 21:33 Inactive
@0618 0618 temporarily deployed to ci September 26, 2022 21:33 Inactive
Copy link
Contributor

@slaymance slaymance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0618 0618 merged commit 959db38 into main Sep 26, 2022
@0618 0618 deleted the fix-log-failure-metric branch September 26, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants