chore(ui-react-core): Migrate useInitMachine to ui-react-core #2754
Conversation
|
| expect(initializeMachine).toHaveBeenCalledTimes(1); | ||
|
|
||
| // change the input props of the hook to get the useEffect to run again | ||
| data = { mutated: 'dataObject' }; |
There was a problem hiding this comment.
Prefer to avoid mutating test variables to achieve a desired behavior as it increases fragility and the behavior itself can be difficult for future maintainers to comprehend the context of.
As an alternative, the rerender API probably provides handling it through the testing library, maybe try the docs
There was a problem hiding this comment.
Good call. I found a way to use the rerender API to handle this
| export default function useAuthenticatorInitMachine( | ||
| data: AuthenticatorMachineOptions | ||
| ): void { | ||
| const { route, initializeMachine } = useAuthenticator(({ route }) => [route]); |
There was a problem hiding this comment.
Not like a huge deal or anything but we could declare the selector param outside the scope of useAuthenticatorInitMachine to give it a static reference between renders
There was a problem hiding this comment.
"React Hook useAuthenticator cannot be called at the top level. React Hooks must be called in a React function component or a custom React Hook function."
...act-core/src/Authenticator/hooks/useAuthenticatorInitMachine/useAuthenticatorInitMachine.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| expect(initializeMachine).toHaveBeenCalledTimes(1); | ||
|
|
||
| // change the input props of the hook to get the useEffect to run again | ||
| data = { mutated: 'dataObject' }; | ||
| rerender(); | ||
| rerender({ data: modifiedData }); |
Description of changes
Migrates
useInitMachinehook to theui-react-corepackage.useAuthenticatorInitMachineIssue #, if available
Description of how you validated changes
Wrote unit tests, and tested for false positive.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.