Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-react-native): Add SignUp subcomponent #2813

Merged
merged 9 commits into from
Oct 26, 2022
Merged

feat(ui-react-native): Add SignUp subcomponent #2813

merged 9 commits into from
Oct 26, 2022

Conversation

ioanabrooks
Copy link
Contributor

@ioanabrooks ioanabrooks commented Oct 25, 2022 •
edited
Loading

Description of changes

  • Add SignUp subcomponent
  • Add Divider primitive

Issue #, if available

Description of how you validated changes

Kapture 2022-10-25 at 13 24 32

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2661b75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 7 alerts when merging 0f643ed into 5a10d31 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 7 alerts when merging 466ef01 into 5a10d31 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 7 alerts when merging 2dfdb00 into 198eedc - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 7 alerts when merging 0ba69e4 into d6d2e27 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

@ioanabrooks ioanabrooks marked this pull request as ready for review October 25, 2022 23:04
@ioanabrooks ioanabrooks requested a review from a team as a code owner October 25, 2022 23:04
@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 2 alerts when merging 8a7dd15 into d6d2e27 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2022 23:25 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2022 23:25 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2022 23:25 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 25, 2022 23:25 Inactive
calebpollman
calebpollman reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple questions but LGTM

@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 00:18 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 00:18 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 00:18 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 00:18 Inactive
calebpollman
calebpollman reviewed Oct 26, 2022
View reviewed changes
.../react-native/src/Authenticator/common/FederatedProviderButtons/FederatedProviderButtons.tsx
Comment on lines -41 to +42
{/* TODO add divider line */}
<Text style={styles.text}>Or</Text>
<Divider labelStyle={styles.text}>Or</Divider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

calebpollman
calebpollman previously approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:05 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:05 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:05 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:41 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:41 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:41 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 26, 2022 20:41 Inactive
@ioanabrooks ioanabrooks merged commit 3af7e01 into rna/main Oct 26, 2022
@ioanabrooks ioanabrooks deleted the rna/sign-up branch October 26, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebpollman calebpollman calebpollman approved these changes

@joebuono joebuono joebuono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioanabrooks @calebpollman @joebuono