Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-react-native): add RadioGroup uncontrolled support #2816

Merged
merged 3 commits into from
Oct 26, 2022
Merged

feat(ui-react-native): add RadioGroup uncontrolled support #2816

merged 3 commits into from
Oct 26, 2022

Conversation

calebpollman
Copy link
Member

Description of changes

Add RadioGroup uncontrolled support

Issue #, if available

NA

Description of how you validated changes

Manual tests, unit tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested a review from a team as a code owner October 25, 2022 21:51
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3ff4903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@calebpollman calebpollman added the run-tests Adding this label will trigger tests to run label Oct 25, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Oct 25, 2022
joebuono
joebuono previously approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@joebuono joebuono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@calebpollman calebpollman added the run-tests Adding this label will trigger tests to run label Oct 25, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Oct 25, 2022
ioanabrooks
ioanabrooks previously approved these changes Oct 25, 2022
View reviewed changes
@calebpollman calebpollman added the run-tests Adding this label will trigger tests to run label Oct 25, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Oct 25, 2022
@calebpollman calebpollman temporarily deployed to ci October 26, 2022 00:03 Inactive
@calebpollman calebpollman temporarily deployed to ci October 26, 2022 00:03 Inactive
@calebpollman calebpollman temporarily deployed to ci October 26, 2022 00:03 Inactive
@calebpollman calebpollman temporarily deployed to ci October 26, 2022 00:03 Inactive
@calebpollman calebpollman merged commit d75fedb into aws-amplify:rna/main Oct 26, 2022
@calebpollman calebpollman deleted the rna/add-radio-group-uncontrolled-mode branch October 26, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebuono joebuono joebuono approved these changes

@ioanabrooks ioanabrooks ioanabrooks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebpollman @joebuono @ioanabrooks