Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rna): ForceNewPassword subcomponent #2823

Merged
merged 7 commits into from
Oct 26, 2022
Merged

Conversation

joebuono
Copy link
Contributor

Description of changes

This PR adds the ConfirmResetPassword subcomponent for the RNA.

Issue #, if available

Description of how you validated changes

Wrote unit tests and Storybook stories.

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joebuono joebuono requested a review from a team as a code owner October 25, 2022 23:57
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

⚠️ No Changeset found

Latest commit: 874ffb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joebuono joebuono temporarily deployed to ci October 26, 2022 00:33 Inactive
@joebuono joebuono temporarily deployed to ci October 26, 2022 00:33 Inactive
@joebuono joebuono temporarily deployed to ci October 26, 2022 00:34 Inactive
@joebuono joebuono temporarily deployed to ci October 26, 2022 00:34 Inactive
isPending,
toSignIn,
}) => {
const { getChangePasswordText, getChangingText, getBackToSignInText } =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other PRs, just thinking we can destructure this outside the component

calebpollman
calebpollman previously approved these changes Oct 26, 2022
@joebuono joebuono temporarily deployed to ci October 26, 2022 20:28 Inactive
@joebuono joebuono temporarily deployed to ci October 26, 2022 20:28 Inactive
@joebuono joebuono temporarily deployed to ci October 26, 2022 20:28 Inactive
@joebuono joebuono temporarily deployed to ci October 26, 2022 20:28 Inactive
@joebuono joebuono merged commit 646e894 into rna/main Oct 26, 2022
@joebuono joebuono deleted the rna/force-new-password branch October 26, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants