Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-react-native): Add theming for Label primitive #2895

Merged
merged 7 commits into from
Nov 8, 2022
Merged

feat(ui-react-native): Add theming for Label primitive #2895

merged 7 commits into from
Nov 8, 2022

Conversation

ioanabrooks
Copy link
Contributor

@ioanabrooks ioanabrooks commented Nov 4, 2022 •
edited
Loading

Description of changes

The changes in this PR will:

  • Add theming to Label primitive
  • Fix bug in token replacement logic
  • Add more unit tests
  • Add stories

Issue #, if available

Description of how you validated changes

Unit tests and Storybook:

Screen Shot 2022-11-04 at 4 02 38 PM

Screen Shot 2022-11-04 at 3 34 37 PM

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d166219

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 01:21 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 01:21 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 01:21 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 01:21 Inactive
@ioanabrooks ioanabrooks marked this pull request as ready for review November 4, 2022 23:34
@ioanabrooks ioanabrooks requested a review from a team as a code owner November 4, 2022 23:34
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 23:51 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 23:51 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 23:51 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 4, 2022 23:51 Inactive
joebuono
joebuono reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@joebuono joebuono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just had a few nits.

examples/react-native/storybook/stories/Label.stories.tsx Show resolved Hide resolved
examples/react-native/storybook/stories/Label.stories.tsx Show resolved Hide resolved
packages/react-native/src/primitives/Label/styles.ts Outdated Show resolved Hide resolved
packages/react-native/src/primitives/Label/types.ts Outdated Show resolved Hide resolved
joebuono
joebuono previously approved these changes Nov 7, 2022
View reviewed changes
@ioanabrooks ioanabrooks temporarily deployed to ci November 7, 2022 23:18 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 7, 2022 23:18 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 7, 2022 23:18 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 7, 2022 23:18 Inactive
joebuono
joebuono previously approved these changes Nov 8, 2022
View reviewed changes
@ioanabrooks ioanabrooks temporarily deployed to ci November 8, 2022 01:29 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 8, 2022 01:29 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 8, 2022 01:29 Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci November 8, 2022 01:29 Inactive
@ioanabrooks ioanabrooks merged commit 775ee5d into rna/main Nov 8, 2022
@ioanabrooks ioanabrooks deleted the rna/themed-label branch November 8, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebpollman calebpollman calebpollman approved these changes

@joebuono joebuono joebuono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioanabrooks @calebpollman @joebuono