Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-react-native): Add theming for IconButton primitive #2950

Merged
merged 11 commits into from
Nov 18, 2022

Conversation

joebuono
Copy link
Contributor

@joebuono joebuono commented Nov 11, 2022

Description of changes

  • Removed unused text property from styles
  • Updated unit tests to use @testing-library/react-native

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joebuono joebuono requested a review from a team as a code owner November 11, 2022 19:40
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

⚠️ No Changeset found

Latest commit: 0b6a9c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const { components, opacities } = theme.tokens;

return StyleSheet.create({
pressed: { opacity: opacities[60], ...components?.iconbutton.pressed },
Copy link
Member

@calebpollman calebpollman Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking we should probably also provide a container button prop so users can apply the theme to the Pressable when its not pressed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Also disabled and size.

@calebpollman calebpollman temporarily deployed to ci November 12, 2022 00:30 Inactive
@calebpollman calebpollman temporarily deployed to ci November 12, 2022 00:30 Inactive
@calebpollman calebpollman temporarily deployed to ci November 12, 2022 00:30 Inactive
@calebpollman calebpollman temporarily deployed to ci November 12, 2022 00:30 Inactive
@joebuono joebuono temporarily deployed to ci November 15, 2022 22:04 Inactive
@joebuono joebuono temporarily deployed to ci November 15, 2022 22:04 Inactive
@joebuono joebuono temporarily deployed to ci November 15, 2022 22:04 Inactive
@joebuono joebuono temporarily deployed to ci November 15, 2022 22:04 Inactive
@calebpollman
Copy link
Member

LGTM. Just to confirm, did we check if it impacts usage in the InApp Messaging components?

@joebuono joebuono temporarily deployed to ci November 15, 2022 23:56 Inactive
@joebuono joebuono temporarily deployed to ci November 15, 2022 23:56 Inactive
@joebuono joebuono temporarily deployed to ci November 16, 2022 02:57 Inactive
@joebuono joebuono temporarily deployed to ci November 16, 2022 02:57 Inactive
@joebuono joebuono temporarily deployed to ci November 16, 2022 02:57 Inactive
@joebuono joebuono temporarily deployed to ci November 16, 2022 02:57 Inactive
ioanabrooks
ioanabrooks previously approved these changes Nov 18, 2022
@calebpollman calebpollman temporarily deployed to ci November 18, 2022 02:36 Inactive
@calebpollman calebpollman temporarily deployed to ci November 18, 2022 02:36 Inactive
@calebpollman calebpollman temporarily deployed to ci November 18, 2022 02:36 Inactive
@calebpollman calebpollman temporarily deployed to ci November 18, 2022 02:36 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 18:42 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 18:42 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 18:42 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 18:42 Inactive
@joebuono
Copy link
Contributor Author

joebuono commented Nov 18, 2022

LGTM. Just to confirm, did we check if it impacts usage in the InApp Messaging components?

Just checked and it doesn't appear to impact InApp Messaging

@joebuono joebuono temporarily deployed to ci November 18, 2022 20:55 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 20:55 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 20:55 Inactive
@joebuono joebuono temporarily deployed to ci November 18, 2022 20:55 Inactive
@joebuono joebuono merged commit 4f67aaa into rna/main Nov 18, 2022
@joebuono joebuono deleted the rna/themed-icon-button branch November 18, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants