-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-react-native): Add theming for IconButton primitive #2950
Conversation
|
const { components, opacities } = theme.tokens; | ||
|
||
return StyleSheet.create({ | ||
pressed: { opacity: opacities[60], ...components?.iconbutton.pressed }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking we should probably also provide a container
button
prop so users can apply the theme to the Pressable
when its not pressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Also disabled and size.
LGTM. Just to confirm, did we check if it impacts usage in the InApp Messaging components? |
Just checked and it doesn't appear to impact InApp Messaging |
Description of changes
text
property from styles@testing-library/react-native
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.