Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-react-native): omit checkbox from themed Components #3034

Merged
merged 1 commit into from
Nov 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/react-native/src/theme/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,17 @@ export type StrictTokens = ReactNativeTokens<'required'>;
// Everything optional for custom themes
export type Tokens = ReactNativeTokens<'optional'>;

// omitted from custom themes until used in another component/publicly available
type OmittedComponents = 'checkbox' | 'divider' | 'tabs';
ioanabrooks marked this conversation as resolved.
Show resolved Hide resolved

/**
* A custom Theme with all properties optional.
*/
export interface Theme {
/**
* Custom component styles
*/
components?: Omit<Components<'input'>, 'divider' | 'tabs'>;
components?: Omit<Components<'input'>, OmittedComponents>;
/**
* Component and component agnostic tokens.
*/
Expand Down